Moodle
  1. Moodle
  2. MDL-34696 enrol improvements 2.4 META
  3. MDL-34852

allow editing of manual/self enrolment times not just dates

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Enrolments
    • Labels:
    • Testing Instructions:
      Hide

      1/ edit manual enrolment - verify it is possible to modify time and that enrolment data is visible.
      1/ edit self enrolment - verify it is possible to modify time and that enrolment data is visible.

      Show
      1/ edit manual enrolment - verify it is possible to modify time and that enrolment data is visible. 1/ edit self enrolment - verify it is possible to modify time and that enrolment data is visible.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w33_MDL-34852_m24_enroledit
    • Rank:
      43367

      Description

      At present you can only change data of enrolment limits, but sometimes you need to specify hours and minutes too...

      At the same time we could add timecreated as read-only element into the edit form.

        Activity

        Hide
        Aparup Banerjee added a comment -

        integrated into master only. Thanks.

        Show
        Aparup Banerjee added a comment - integrated into master only. Thanks.
        Hide
        Frédéric Massart added a comment - - edited

        Test failed.

        It is probably an easy fix, but I just noticed that the 'Enrolment created' date is set to now().
        Also I think it could be more readable if it has the same format than on the enrolment page.

        Enrolment created 15 August 2012 09 25 
        
        Show
        Frédéric Massart added a comment - - edited Test failed. It is probably an easy fix, but I just noticed that the 'Enrolment created' date is set to now(). Also I think it could be more readable if it has the same format than on the enrolment page. Enrolment created 15 August 2012 09 25
        Hide
        Petr Škoda added a comment -

        oh, thanks a lot, should be fixed now - I had to use static element instead of the freezing, hacky but I agree it looks better and it does not round the time.

        Show
        Petr Škoda added a comment - oh, thanks a lot, should be fixed now - I had to use static element instead of the freezing, hacky but I agree it looks better and it does not round the time.
        Hide
        Petr Škoda added a comment -

        to integrators: please pull in two more commits and restart testing

        Show
        Petr Škoda added a comment - to integrators: please pull in two more commits and restart testing
        Hide
        Aparup Banerjee added a comment -

        ah yes, definitely static is better just for showing.

        ok i've picked those two commits into master (could've been squashed but..), please retest.

        Show
        Aparup Banerjee added a comment - ah yes, definitely static is better just for showing. ok i've picked those two commits into master (could've been squashed but..), please retest.
        Hide
        Frédéric Massart added a comment -

        Test all good! Cheers!

        Show
        Frédéric Massart added a comment - Test all good! Cheers!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility!

        Many thanks for your collaboration, yay!

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility! Many thanks for your collaboration, yay! Closing, ciao
        Hide
        Mary Cooch added a comment -

        Removing docs_required label as this is now documented here http://docs.moodle.org/24/en/Manual_enrolment and http://docs.moodle.org/24/en/Self_enrolment

        Show
        Mary Cooch added a comment - Removing docs_required label as this is now documented here http://docs.moodle.org/24/en/Manual_enrolment and http://docs.moodle.org/24/en/Self_enrolment

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: