Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34696 enrol improvements 2.4 META
  3. MDL-34852

allow editing of manual/self enrolment times not just dates

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Enrolments
    • Labels:
    • Testing Instructions:
      Hide

      1/ edit manual enrolment - verify it is possible to modify time and that enrolment data is visible.
      1/ edit self enrolment - verify it is possible to modify time and that enrolment data is visible.

      Show
      1/ edit manual enrolment - verify it is possible to modify time and that enrolment data is visible. 1/ edit self enrolment - verify it is possible to modify time and that enrolment data is visible.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w33_MDL-34852_m24_enroledit

      Description

      At present you can only change data of enrolment limits, but sometimes you need to specify hours and minutes too...

      At the same time we could add timecreated as read-only element into the edit form.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            nebgor Aparup Banerjee added a comment -

            integrated into master only. Thanks.

            Show
            nebgor Aparup Banerjee added a comment - integrated into master only. Thanks.
            Hide
            fred Frédéric Massart added a comment - - edited

            Test failed.

            It is probably an easy fix, but I just noticed that the 'Enrolment created' date is set to now().
            Also I think it could be more readable if it has the same format than on the enrolment page.

            Enrolment created 15 August 2012 09 25 

            Show
            fred Frédéric Massart added a comment - - edited Test failed. It is probably an easy fix, but I just noticed that the 'Enrolment created' date is set to now(). Also I think it could be more readable if it has the same format than on the enrolment page. Enrolment created 15 August 2012 09 25
            Hide
            skodak Petr Skoda added a comment -

            oh, thanks a lot, should be fixed now - I had to use static element instead of the freezing, hacky but I agree it looks better and it does not round the time.

            Show
            skodak Petr Skoda added a comment - oh, thanks a lot, should be fixed now - I had to use static element instead of the freezing, hacky but I agree it looks better and it does not round the time.
            Hide
            skodak Petr Skoda added a comment -

            to integrators: please pull in two more commits and restart testing

            Show
            skodak Petr Skoda added a comment - to integrators: please pull in two more commits and restart testing
            Hide
            nebgor Aparup Banerjee added a comment -

            ah yes, definitely static is better just for showing.

            ok i've picked those two commits into master (could've been squashed but..), please retest.

            Show
            nebgor Aparup Banerjee added a comment - ah yes, definitely static is better just for showing. ok i've picked those two commits into master (could've been squashed but..), please retest.
            Hide
            fred Frédéric Massart added a comment -

            Test all good! Cheers!

            Show
            fred Frédéric Massart added a comment - Test all good! Cheers!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility!

            Many thanks for your collaboration, yay!

            Closing, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility! Many thanks for your collaboration, yay! Closing, ciao
            Hide
            marycooch Mary Cooch added a comment -

            Removing docs_required label as this is now documented here http://docs.moodle.org/24/en/Manual_enrolment and http://docs.moodle.org/24/en/Self_enrolment

            Show
            marycooch Mary Cooch added a comment - Removing docs_required label as this is now documented here http://docs.moodle.org/24/en/Manual_enrolment and http://docs.moodle.org/24/en/Self_enrolment

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/12