Added patch to add course display as a course default option. I was not able to use COURSE_DISPLAY_SINGLEPAGE and COURSE_DISPLAY_MULTIPAGE as values in admin/settings/courses.php, since it seems that the file that defined those variables isn't being included.

Thanks for working on that and sharing the result.

Hi Rex,

Thanks for this, looks great to submit this ASAP. I think we should use the constants though.

We could include courselib in that admin setting or move the constants to moodlelib. I think rather than bloat the admin menu with any more files you could move those constants to moodlelib.

Dan, I did the following:

• Moved COURSE_DISPLAY_SINGLEPAGE and COURSE_DISPLAY_MULTIPAGE constants from courselib to moodlelib.php
• Using course display constants in course default admin setting page

My latest changes are on github.

Thanks Rex, i'm submitting this for integration. Are you able to add testing instructions to this change?

Note, the integrator might have a different opinion about moving those constants to me I did have a thought that we might be good having a constants.php file that we could start declaring these in because it might reduce include library bloat. Or I could be off the mark

Added testing instructions.

Thanks a lot Rex!

1) Something to consider, the creation of one lib/constants.php, sure.
2) The preferred way to name the help lang strings for admin settings is "xxx_desc", not "xxx_help" (to avoid conflicts with forms tooltips. Just a detail.
3) No matter of 2), I'm integrating this now, thanks!

Note: I've added one extra commit fixing some incorrect whitespace, please configure your editor/ide to detect/fix those occurrences.

Integrated, thanks (23 & master)!

Tested on 2.3 and master.
All working as expected.
Test passed.

YEAR!*

CAF*, TOT!*

• Your effort amazingly resulted. (unbelievable :-P)
• Closing as fixed.
• Tons of thanks.

Removing docs_required label as I've added a note about the new setting to http://docs.moodle.org/en/Course_settings