Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34868

Update Google Maps API V2 key setting description

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.4, 2.3.1, 2.4
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide

      1/ go to location settings
      2/ verify the new Google Maps API setting name and description, it should give enough info necessary for getting the right keys

      Show
      1/ go to location settings 2/ verify the new Google Maps API setting name and description, it should give enough info necessary for getting the right keys
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w34_MDL-34868_m24_gmapsv2

      Description

      Unable to add a Google Maps API key to Moodle.

      Settings > Site admin > Location > Location settings > IP address lookup

      The page for Google Maps API key generation is no longer exists at http://code.google.com/apis/maps/signup.html.

      Google says: The API keys generated by this page are no longer available. Please see the relevant section below for the API you using.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              salvetore Michael de Raadt added a comment - - edited

              It looks like this API key is no longer needed.

              ...So it might be worth considering dropping this setting.

              Show
              salvetore Michael de Raadt added a comment - - edited It looks like this API key is no longer needed. ...So it might be worth considering dropping this setting.
              Hide
              skodak Petr Skoda added a comment -

              No, the API key is still required, just the admin UI was changed. You can still register your v2 keys there. I just tried it, there is no bug in Moodle.

              I am going to tweak the admin setting text to indicate that moodle requires v2 API key. In 2.4 we should probably switch to v3, but that is a separate issue...

              Show
              skodak Petr Skoda added a comment - No, the API key is still required, just the admin UI was changed. You can still register your v2 keys there. I just tried it, there is no bug in Moodle. I am going to tweak the admin setting text to indicate that moodle requires v2 API key. In 2.4 we should probably switch to v3, but that is a separate issue...
              Hide
              skodak Petr Skoda added a comment -

              Thanks for the report.

              Show
              skodak Petr Skoda added a comment - Thanks for the report.
              Hide
              skodak Petr Skoda added a comment -
              • The Google Maps JavaScript API V3 and the Maps Image APIs previously did not require an API console key. This is still supported for legacy applications to ensure backwards compatibility, but is no longer recommended for new applications.

              From https://developers.google.com/maps/faq#recommended

              Show
              skodak Petr Skoda added a comment - The Google Maps JavaScript API V3 and the Maps Image APIs previously did not require an API console key. This is still supported for legacy applications to ensure backwards compatibility, but is no longer recommended for new applications. From https://developers.google.com/maps/faq#recommended
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Integrated, thanks! (22, 23 & master)

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (22, 23 & master)
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Tested while reviewing, passed.

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Tested while reviewing, passed.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              YEAR!*

              CAF*, TOT!*

              • Your effort amazingly resulted. (unbelievable :-P)
              • Closing as fixed.
              • Tons of thanks.
              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - YEAR!* CAF*, TOT!* Your effort amazingly resulted. (unbelievable :-P) Closing as fixed. Tons of thanks.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    10/Sep/12