Details

    • Rank:
      43399

      Description

      we need to hack pluginlib to load the base class from editor_tinymce....

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          Hi Petr,

          Surely we can use context_system on the uninstallation page, and not encourage more use of: $PAGE->set_context(null);

          Given that the code that deals with that null parameter says:

                      // extremely ugly hack which sets context to some value in order to prevent warnings,
                      // use only for core error handling!!!!
          
          Show
          Dan Poltawski added a comment - Hi Petr, Surely we can use context_system on the uninstallation page, and not encourage more use of: $PAGE->set_context(null); Given that the code that deals with that null parameter says: // extremely ugly hack which sets context to some value in order to prevent warnings, // use only for core error handling!!!!
          Hide
          Petr Škoda added a comment -

          done

          Show
          Petr Škoda added a comment - done
          Hide
          Dan Poltawski added a comment -

          Integrated, thanks.

          Show
          Dan Poltawski added a comment - Integrated, thanks.
          Hide
          Rajesh Taneja added a comment -

          Works as described.

          Thanks for improving this, Petr.

          FYI:
          When subplugin is uninstalled, uninstall link is still visible. But that is true for other modules as well. Seems it should be install rather then uninstall or hidden.

          Show
          Rajesh Taneja added a comment - Works as described. Thanks for improving this, Petr. FYI: When subplugin is uninstalled, uninstall link is still visible. But that is true for other modules as well. Seems it should be install rather then uninstall or hidden.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          YEAR!*

          CAF*, TOT!*

          • Your effort amazingly resulted. (unbelievable :-P)
          • Closing as fixed.
          • Tons of thanks.
          Show
          Eloy Lafuente (stronk7) added a comment - YEAR!* CAF*, TOT!* Your effort amazingly resulted. (unbelievable :-P) Closing as fixed. Tons of thanks.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: