Moodle
  1. Moodle
  2. MDL-34887

Create hyperlinks to names in Assignments

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.3.2
    • Component/s: Assignment
    • Labels:
    • Rank:
      43412

      Description

      I am using the new "Assignment" tool in Moodle 2.3.1+. I like it, however, I suggest that the names of the students be "hyperlinked" in order to get to their profile. In the old assignment tool, in Moodle 2.2+, names were always hyperlinked, and I used this frequently. I am attaching a graphic to show you what I mean.

        Activity

        Hide
        Michael de Raadt added a comment -

        Thanks for suggesting that.

        It's a simple idea, but it might need a bit of work in the new assignment grading page architecture.

        Show
        Michael de Raadt added a comment - Thanks for suggesting that. It's a simple idea, but it might need a bit of work in the new assignment grading page architecture.
        Hide
        Rick Jerz added a comment -

        I'll tell you why it is important to me. One of my first assignments is for students to upload a photo of themselves. Between suggesting that they upload a photo to their profile, and this "Upload photo" assignment, I am able to make sure that I get their photos into their profiles. The "Upload Photo" assignment also gives students their first experience with the Moodle "Upload Assignment" tool, which helps reduce any problems later in the semester.

        So, when grading this assignment, I review or edit their photo, then I go into the assignments page (shown in graphic), I award them points, and then (in Moodle 2.2+ and prior versions), I click on their name and upload the new photo. One problem that I have always had, however, is that after editing their profile, Moodle had returned me to the Home|Users area in Moodle. I would have preferred being returned to this Assignment page.

        Well, this is what I do. Maybe it is minor, but I still think that it is a good practice to provide hyperlinks to common data whenever possible.

        Show
        Rick Jerz added a comment - I'll tell you why it is important to me. One of my first assignments is for students to upload a photo of themselves. Between suggesting that they upload a photo to their profile, and this "Upload photo" assignment, I am able to make sure that I get their photos into their profiles. The "Upload Photo" assignment also gives students their first experience with the Moodle "Upload Assignment" tool, which helps reduce any problems later in the semester. So, when grading this assignment, I review or edit their photo, then I go into the assignments page (shown in graphic), I award them points, and then (in Moodle 2.2+ and prior versions), I click on their name and upload the new photo. One problem that I have always had, however, is that after editing their profile, Moodle had returned me to the Home|Users area in Moodle. I would have preferred being returned to this Assignment page. Well, this is what I do. Maybe it is minor, but I still think that it is a good practice to provide hyperlinks to common data whenever possible.
        Hide
        Raymond Antonio added a comment - - edited

        Hi Michael and Rick,

        This my proposed fix for this tracker and it sits on my github repo : MDL-34887
        https://github.com/raymondAntonio/moodle/tree/MDL-34887

        and here is the diff:

        https://github.com/raymondAntonio/moodle/commit/a1d31f73fabf7bc180f9608f4c0e9b082d44bd85#diff-0

        Cheers

        Show
        Raymond Antonio added a comment - - edited Hi Michael and Rick, This my proposed fix for this tracker and it sits on my github repo : MDL-34887 https://github.com/raymondAntonio/moodle/tree/MDL-34887 and here is the diff: https://github.com/raymondAntonio/moodle/commit/a1d31f73fabf7bc180f9608f4c0e9b082d44bd85#diff-0 Cheers
        Hide
        Damyon Wiese added a comment -

        This is a small change and looks good to me. It uses $row->id instead of $row->userid because there is separate oracle patch that will remove $row->userid. This change works before or after the oracle patch.

        Show
        Damyon Wiese added a comment - This is a small change and looks good to me. It uses $row->id instead of $row->userid because there is separate oracle patch that will remove $row->userid. This change works before or after the oracle patch.
        Hide
        Rick Jerz added a comment -

        I must confess that I am a novice when it comes to github. It appears that maybe what I could do is to download the "gradingtable.php" file, and simply move it to my server's install of Moodle replacing what might be there already.

        Is this correct? Or do I need to do more?

        Usually, I let more skilled people (like Damyon) look things over.

        Show
        Rick Jerz added a comment - I must confess that I am a novice when it comes to github. It appears that maybe what I could do is to download the "gradingtable.php" file, and simply move it to my server's install of Moodle replacing what might be there already. Is this correct? Or do I need to do more? Usually, I let more skilled people (like Damyon) look things over.
        Hide
        Damyon Wiese added a comment -

        Hi Rick,

        That's not the best way to do it - you might accidentally overwrite a bug fix or cause other side effects. Particularly if you are not using the same version of Moodle that Raymond was when he wrote this patch (2.4dev).

        If you only want this fix the easiest way is to look at the diff url which lists the specific changes and apply them manually.

        When reading the diff:

        mod/assign/gradingtable.php is the file to change:
        Each line has a line number on the left - but they may be different for you if you have a different version of Moodle.
        Lines in red are removed.
        Lines in green have been added.
        The other lines are for context - ie you want to modify the col_fullname function.

        So to apply this patch you remove 2 lines and cut and paste in the 4 green lines (remove the + character from the front of the line).

        Hope this helps.

        Show
        Damyon Wiese added a comment - Hi Rick, That's not the best way to do it - you might accidentally overwrite a bug fix or cause other side effects. Particularly if you are not using the same version of Moodle that Raymond was when he wrote this patch (2.4dev). If you only want this fix the easiest way is to look at the diff url which lists the specific changes and apply them manually. When reading the diff: mod/assign/gradingtable.php is the file to change: Each line has a line number on the left - but they may be different for you if you have a different version of Moodle. Lines in red are removed. Lines in green have been added. The other lines are for context - ie you want to modify the col_fullname function. So to apply this patch you remove 2 lines and cut and paste in the 4 green lines (remove the + character from the front of the line). Hope this helps.
        Hide
        Dan Poltawski added a comment -

        Converting this to a bug, as it is more suited to a bug vs 2.2 (and thus makes sense to backport).

        Show
        Dan Poltawski added a comment - Converting this to a bug, as it is more suited to a bug vs 2.2 (and thus makes sense to backport).
        Hide
        Dan Poltawski added a comment -

        Integrated to 2.3 and master. Thanks!

        Show
        Dan Poltawski added a comment - Integrated to 2.3 and master. Thanks!
        Hide
        Rick Jerz added a comment -

        Damyon, it appears that Dan has the fix moving along. I typically update my Moodle every three or four weeks, so I will be getting the real code soon.

        Thanks everyone for working on this so quickly.

        Show
        Rick Jerz added a comment - Damyon, it appears that Dan has the fix moving along. I typically update my Moodle every three or four weeks, so I will be getting the real code soon. Thanks everyone for working on this so quickly.
        Hide
        Tim Barker added a comment -

        Tested and this passed, great work!

        Show
        Tim Barker added a comment - Tested and this passed, great work!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        YEAR!*

        CAF*, TOT!*

        • Your effort amazingly resulted. (unbelievable :-P)
        • Closing as fixed.
        • Tons of thanks.
        Show
        Eloy Lafuente (stronk7) added a comment - YEAR!* CAF*, TOT!* Your effort amazingly resulted. (unbelievable :-P) Closing as fixed. Tons of thanks.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: