Moodle

Allow HTML block instances to specify additional CSS classes

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.4
  • Fix Version/s: 2.4
  • Component/s: Blocks
  • Testing Instructions:
    Hide

    Create a new course.
    Add multiple HTML blocks with titles and content.
    Inspect each of the block's CSS class values in their outer divs (should be something like "block_html block")
    In each block add some values to the "Additional HTML classes" fields and save.
    Inspect each of the block's CSS class values again and the classes specified in the previous step should be appended to the original classes.

    Show
    Create a new course. Add multiple HTML blocks with titles and content. Inspect each of the block's CSS class values in their outer divs (should be something like "block_html block") In each block add some values to the "Additional HTML classes" fields and save. Inspect each of the block's CSS class values again and the classes specified in the previous step should be appended to the original classes.
  • Affected Branches:
    MOODLE_24_STABLE
  • Fixed Branches:
    MOODLE_24_STABLE
  • Pull from Repository:
  • Pull Master Branch:
  • Pull Master Diff URL:

Description

This patch adds a field to the per-instance configuration of the Moodle HTML block that allows an admin to specify additional CSS classes to aid with theming.

Issue Links

has a non-specific relationship to

Improvement - An enhancement to an existing Moodle feature. MDL-35042 Allow HTML block instances advanced setting to be toggled

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Frédéric Massart added a comment -

Hi Aaron, thanks for this improvement!

Could you consider adding a few testing instructions? I'd also recommend removing the <br /> from the language string, adding a help button seem to be a good solution if extra information is required.

Thanks!

Show
Frédéric Massart added a comment - Hi Aaron, thanks for this improvement! Could you consider adding a few testing instructions? I'd also recommend removing the <br /> from the language string, adding a help button seem to be a good solution if extra information is required. Thanks!
Hide
Permalink
Aaron Barnes added a comment -

Done! Thanks Frederic.

Show
Aaron Barnes added a comment - Done! Thanks Frederic.
Hide
Permalink
Michael de Raadt added a comment -

This will still need testing instructions before it makes it through Integration.

Show
Michael de Raadt added a comment - This will still need testing instructions before it makes it through Integration.
Hide
Permalink
Aaron Barnes added a comment -

Added testing instructions.

Show
Aaron Barnes added a comment - Added testing instructions.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Just guessing if this could be hidden via admin->plugins->blocks->html->setting in order to prevent people to use it as far as can be highly technical for mortals... for your consideration.

Integrated (master only), also added the documentation and ui labels, thanks!

Show
Eloy Lafuente (stronk7) added a comment - Just guessing if this could be hidden via admin->plugins->blocks->html->setting in order to prevent people to use it as far as can be highly technical for mortals... for your consideration. Integrated (master only), also added the documentation and ui labels, thanks!
Hide
Permalink
Andrew Davis added a comment -

Works as described. Passing.

Show
Andrew Davis added a comment - Works as described. Passing.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

YEAR!*

CAF*, TOT!*

  • Your effort amazingly resulted. (unbelievable :-P)
  • Closing as fixed.
  • Tons of thanks.
Show
Eloy Lafuente (stronk7) added a comment - YEAR!* CAF*, TOT!* Your effort amazingly resulted. (unbelievable :-P) Closing as fixed. Tons of thanks.
Hide
Permalink
Mary Cooch added a comment -

Removing docs_required label as this is documented here http://docs.moodle.org/24/en/HTML_block

Show
Mary Cooch added a comment - Removing docs_required label as this is documented here http://docs.moodle.org/24/en/HTML_block

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: