[MDL-34907] JavaScript error in assignment upgrade tool - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE
Fixed Branches:
MOODLE_23_STABLE
Pull from Repository:
git://github.com/raymondAntonio/moodle.git
Pull Master Branch:
~~MDL-34907~~
Pull Master Diff URL:
https://github.com/raymondAntonio/moodle/commit/77b3e35105ac24139353c25ebda50595b7a7e35f
Workaround:

Hide

None required.

Show
None required.
Testing Instructions:
Hide

goto /admin/tool/assignmentupgrade/listnotupgraded.php

click on the button "upgrade all assignments"

There should be no javascript errors in the console and you should be taken to a confirm page.

goto /admin/tool/assignmentupgrade/listnotupgraded.php

click on the button "upgrade selected assignments" without selecting any assignments

There should be an alert: "No assignments selected" and you should stay on the same page.
Show
goto /admin/tool/assignmentupgrade/listnotupgraded.php click on the button "upgrade all assignments" There should be no javascript errors in the console and you should be taken to a confirm page. goto /admin/tool/assignmentupgrade/listnotupgraded.php click on the button "upgrade selected assignments" without selecting any assignments There should be an alert: "No assignments selected" and you should stay on the same page.

Replication steps:

check console for an error something like :-

Timestamp: 15/08/12 14:16:51

Error: TypeError: M.str.assign is undefined

Source File: http://127.0.0.1/int/master/moodle/lib/javascript.php?rev=1345010974&jsfile=%2Fadmin%2Ftool%2Fassignmentupgrade%2Fmodule.js

Line: 1

Discovered while testing

MDL-35119 Assignment upgrade tool -> 'Upgrade all assignments' button requires users to check any assignment

MDL-34741 switch to YUI2 to 2in3

Participants:: Ankit Agarwal, Aparup Banerjee, Damyon Wiese, David Monllaó, Eloy Lafuente (stronk7), Petr Skoda, Raymond Antonio

Component watchers:: Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie