Loading...

XML

Word

Printable

Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_24_STABLE
Pull from Repository:
git://github.com/skodak/moodle.git
Pull Main Branch:
w43_~~MDL-34915~~_m24_simpleyui
Pull Main Diff URL:
https://github.com/skodak/moodle/compare/master...w43_MDL-34915_m24_simpleyui
Testing Instructions:

Hide

Clear all caches, verify that Moodle UI that uses YUI still works:
1/ navigation
2/ groups UI
3/ enrolments UI
4/ quiz
5/ mod chooser
6/ etc.

Try doing a 'stress test' using the course features demo and the course editing page. Examine if its better/worse than before.

Show
Clear all caches, verify that Moodle UI that uses YUI still works: 1/ navigation 2/ groups UI 3/ enrolments UI 4/ quiz 5/ mod chooser 6/ etc. Try doing a 'stress test' using the course features demo and the course editing page. Examine if its better/worse than before.

Since 3.2.0 there is a new way to initialise global "Y" instance - SimpleYUI, see http://www.yuiblog.com/blog/2010/09/03/coming-inyui-3-2-0-simpleyui

Benefits:

100% backwards compatible
easier to migrate oldstyle YUI2 code because Y is available in global scope everywhere
supposedly easier to understand for JQuery users
somehow seems to make moodle UI flicker less during page load
simplifies static JS in "M.*" scope and module.js files

Potential problems:

performance - are pages are very heavy, it seems that loading more at the beginning makes page init feel faster, the total time measured seems to be the same
encourages different coding styles - it does not fit "YUI.add('moodle-xxx', function(Y) {" much

caused a regression

MDL-36800 JS error from simpleyui: Y.Lang is undefined

Discovered while testing

MDL-36323 Normalise icons present in blocks

has been marked as being related by

MDL-34741 switch to YUI2 to 2in3

MDL-36100 Improve the way that yui_module requires JS modules to reduce number of calls

Participants:: Amy Groshek, Ankit Agarwal, Dan Poltawski, Eloy Lafuente (stronk7), Martin Dougiamas, Petr Skoda