[MDL-34936] get_fast_modinfo should throw debug warnings about missing course->sectioncache - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.3.1, 2.4
Fix Version/s: 2.3.2
Component/s: Course
Labels:
- patch
- triaged

Affected Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE
Fixed Branches:
MOODLE_23_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Master Branch:
~~MDL-34936~~-master-1
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/commit/MDL-34936-master-1
Testing Instructions:
Hide

Ensure that you're enrolled on at least one course

View your /my home page

Confirm that no errors were shown

master instructions

open /blocks/course_overview/locallib.php in your editor

find block_course_overview_get_sorted_courses()

remove the 'sectioncache from the enrol_get_my_courses() call

refresh your /my page

Confirm that a debug message was shown

MOODLE_23_STABLE instructions

open blocks/course_overview/block_course_overview.php in your editor

find get_content()

remove the 'sectioncache from the enrol_get_my_courses() call

refresh your /my page

Confirm that a debug message was shown
Show
Ensure that you're enrolled on at least one course View your /my home page Confirm that no errors were shown master instructions open /blocks/course_overview/locallib.php in your editor find block_course_overview_get_sorted_courses() remove the 'sectioncache from the enrol_get_my_courses() call refresh your /my page Confirm that a debug message was shown MOODLE_23_STABLE instructions open blocks/course_overview/block_course_overview.php in your editor find get_content() remove the 'sectioncache from the enrol_get_my_courses() call refresh your /my page Confirm that a debug message was shown

Description

As an addendum to ~~MDL-34783~~, I was thinking we should probably warn if the provided course is missing the sectioncache property. This is already the case for the modinfo property.

Attachments

Issue Links

Testing discovered

MDL-35089 PHPUnit execution throwing debugging error on get_fast_modinfo() execution

Closed

Activity

People

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Frédéric Massart

Integrator:: Aparup Banerjee

Tester:: Ankit Agarwal

Participants:: Andrew Lyons, Ankit Agarwal, Aparup Banerjee, Eloy Lafuente (stronk7), Frédéric Massart

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 17/Aug/12 11:55 AM

Updated:: 01/Sep/12 2:54 AM

Resolved:: 01/Sep/12 2:54 AM

Fix Release Date:: 10/Sep/12