Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34944

Book module should implement reset framework

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2, 2.4
    • Fix Version/s: 2.3.3
    • Component/s: Book
    • Labels:
    • Testing Instructions:
      Hide
      1. Goto a course which has atleast one book instance (or create one)
      2. Goto course admin>reset
      3. make sure under the heading "Reset not implemented" Book is not listed (click show advanced)
      4. Reset the course.
      5. Make sure no warning msgs related to book is generated.
      Show
      Goto a course which has atleast one book instance (or create one) Goto course admin>reset make sure under the heading "Reset not implemented" Book is not listed (click show advanced) Reset the course. Make sure no warning msgs related to book is generated.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-34944-master

      Description

      At present whenever you reset a course that contains a book instances, it popups a msg saying Reset is not implemented for the book module. Maybe we should just declare the reset function in book/lib.php . This would be consistent behaviour with other resources like URL and Folder.

      /**
       * This function is used by the reset_course_userdata function in moodlelib.
       * @param $data the data submitted from the reset course.
       * @return array status array
       */
      function book_reset_userdata($data) {
          return array();
      }

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Requesting a review

            Show
            ankit_frenz Ankit Agarwal added a comment - Requesting a review
            Hide
            rwijaya Rossiani Wijaya added a comment -

            This looks good.

            +1 for integration.

            Show
            rwijaya Rossiani Wijaya added a comment - This looks good. +1 for integration.
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Thanks for the review Rosie.
            Sending for integration.

            Show
            ankit_frenz Ankit Agarwal added a comment - Thanks for the review Rosie. Sending for integration.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Rebased

            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - Rebased Thanks
            Hide
            nebgor Aparup Banerjee added a comment -

            thanks, itnegrated into 23 and master.

            Show
            nebgor Aparup Banerjee added a comment - thanks, itnegrated into 23 and master.
            Hide
            fred Frédéric Massart added a comment -

            Passing after testing on 2.3 and master. Thanks!

            Show
            fred Frédéric Massart added a comment - Passing after testing on 2.3 and master. Thanks!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio

            This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

            Thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/12