Moodle
  1. Moodle
  2. MDL-33529 external PHPunit tests
  3. MDL-34967

PHPunit test: enrol/externallib.php and enrol/manual/externallib.php

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Enrolments, Web Services
    • Labels:
    • Testing Instructions:
      Hide

      phpunit core_enrol_external_testcase enrol/tests/externallib_test.php
      phpunit enrol_manual_external_testcase enrol/manual/tests/externallib_test.php
      phpunit core_role_external_testcase enrol/tests/externallib_test.php

      Show
      phpunit core_enrol_external_testcase enrol/tests/externallib_test.php phpunit enrol_manual_external_testcase enrol/manual/tests/externallib_test.php phpunit core_role_external_testcase enrol/tests/externallib_test.php
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
    • Rank:
      43546

      Description

      write the PHPunit test

        Activity

        Hide
        Jérôme Mouneyrac added a comment -

        sent for peer-review to Rosie.

        Show
        Jérôme Mouneyrac added a comment - sent for peer-review to Rosie.
        Hide
        Rossiani Wijaya added a comment -

        Hi Jerome,

        Some feedback for all the files:

        1. Remove line 33-40 (duplicate documentation)
        2. it might be better to remove the setUp() and place the global $CFG and require_once on top of the page.

        The reset looks good.

        Show
        Rossiani Wijaya added a comment - Hi Jerome, Some feedback for all the files: Remove line 33-40 (duplicate documentation) it might be better to remove the setUp() and place the global $CFG and require_once on top of the page. The reset looks good.
        Hide
        Jérôme Mouneyrac added a comment -

        Thanks Rosie, sending to integration.

        Show
        Jérôme Mouneyrac added a comment - Thanks Rosie, sending to integration.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Aparup Banerjee added a comment -

        thanks, this test is now integrated into master.

        Show
        Aparup Banerjee added a comment - thanks, this test is now integrated into master.
        Hide
        Aparup Banerjee added a comment -

        tested fine here plus theres nightly tests.

        Show
        Aparup Banerjee added a comment - tested fine here plus theres nightly tests.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio

        This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

        Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: