Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Groups, Web Services
    • Labels:
    • Rank:
      43549

      Description

      write PHPunit tests for group/externallib.php

        Activity

        Hide
        Jérôme Mouneyrac added a comment -

        sent for peer-review to Rosie.

        Show
        Jérôme Mouneyrac added a comment - sent for peer-review to Rosie.
        Hide
        Rossiani Wijaya added a comment -

        Hi Jerome,

        Some feedback for the patch:

        1. Remove line 33-40 (duplicate documentation)
        2. it might be better to remove the setUp() and place the global $CFG and require_once on top of the page.
        3. line 61, 118, 176 - would be better to declare the array variable (eg: $group1 = array())

        The reset looks good.

        Show
        Rossiani Wijaya added a comment - Hi Jerome, Some feedback for the patch: Remove line 33-40 (duplicate documentation) it might be better to remove the setUp() and place the global $CFG and require_once on top of the page. line 61, 118, 176 - would be better to declare the array variable (eg: $group1 = array()) The reset looks good.
        Hide
        Jérôme Mouneyrac added a comment -

        Thanks Rosie, submitting to integration.

        Show
        Jérôme Mouneyrac added a comment - Thanks Rosie, submitting to integration.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Aparup Banerjee added a comment -

        thanks, thats been integrated into master.

        Show
        Aparup Banerjee added a comment - thanks, thats been integrated into master.
        Hide
        Tim Barker added a comment -

        PHPUnit tests run regularly against MySQL and PgSQL and all pass. No need to run them manually.

        Show
        Tim Barker added a comment - PHPUnit tests run regularly against MySQL and PgSQL and all pass. No need to run them manually.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio

        This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

        Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: