Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Web Services
    • Labels:

      Description

      Write PHPunit tests for notes/externallib.php

        Gliffy Diagrams

          Activity

          Hide
          Jérôme Mouneyrac added a comment -

          Sent to Rosie for peer-review.

          Show
          Jérôme Mouneyrac added a comment - Sent to Rosie for peer-review.
          Hide
          Rossiani Wijaya added a comment -

          Hi Jerome,

          Some feedback for the patch:

          1. it might be better to remove the setUp() and place the global $CFG and require_once on top of the page.
          2. removed line 33-39 (duplicate documentation)

          The rest looks good.

          Show
          Rossiani Wijaya added a comment - Hi Jerome, Some feedback for the patch: it might be better to remove the setUp() and place the global $CFG and require_once on top of the page. removed line 33-39 (duplicate documentation) The rest looks good.
          Hide
          Jérôme Mouneyrac added a comment -

          Thanks Rosie, submitting to integration.

          Show
          Jérôme Mouneyrac added a comment - Thanks Rosie, submitting to integration.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Aparup Banerjee added a comment -

          thanks, thats integrated now.

          tester can suggest some additional tests if required

          Show
          Aparup Banerjee added a comment - thanks, thats integrated now. tester can suggest some additional tests if required
          Hide
          Tim Barker added a comment -

          PHPUnit tests run every night int he nightly build against 2.3 and 2.4. They also run at every checkin on the integration CI server.

          There is no need to run the unit tests manually during the Wednesday testing phase.

          Show
          Tim Barker added a comment - PHPUnit tests run every night int he nightly build against 2.3 and 2.4. They also run at every checkin on the integration CI server. There is no need to run the unit tests manually during the Wednesday testing phase.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio

          This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

          Thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: