[MDL-34984] .form-shortname shouldn't be inside the form label in adminsettings - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.2.5, 2.3.1, 2.4
Fix Version/s: 2.2.6, 2.3.3
Component/s: Accessibility, Administration
Labels:
- patch
- triaged

Testing Instructions:

Hide

As admin, go to 'debugging' setting (site admin > developmen > debugging)
use firebug to view the source for 'debug messages' and 'debug' for the selection options.

It should be displayed as :

<div class="form-label">

    <label for="id_s__debug">Debug messages</label>

    <span class="form-shortname">debug</span>

</div>

Show

As admin, go to 'debugging' setting (site admin > developmen > debugging) use firebug to view the source for 'debug messages' and 'debug' for the selection options. It should be displayed as : <div class="form-label"> <label for="id_s__debug">Debug messages</label> <span class="form-shortname">debug</span> </div>

Affected Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Pull from Repository:
git://github.com/rwijaya/moodle.git
Pull Master Branch:
~~MDL-34984~~
Pull Master Diff URL:
https://github.com/rwijaya/moodle/compare/master...MDL-34984

Description

In adminsettings forms the div.form-label contains both the <label> and a span.form-shortname. The span is not actually part of the label text and so should be placed outside of the label tag e.g current:

<div class="form-item clearfix" id="admin-debug">

  <div class="form-label">

    <label for="id_s__debug">Debug messages<span class="form-shortname">debug</span></label>

  </div>

should be

<div class="form-item clearfix" id="admin-debug">

  <div class="form-label">

    <label for="id_s__debug">Debug messages</label>

    <span class="form-shortname">debug</span>

  </div>

Otherwise the browser will run both bits of text together to generate a label similar to "Debug messagesdebug" or " Display debug messagesdebugdisplay".

Attachments

Activity

People

Assignee:: Rossiani Wijaya

Reporter:: David Scotson

Peer reviewer:: Ankit Agarwal

Integrator:: Eloy Lafuente (stronk7)

Tester:: Eloy Lafuente (stronk7)

Participants:: Ankit Agarwal, David Scotson, Eloy Lafuente (stronk7), Michael de Raadt, Rossiani Wijaya

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 0 Start watching this issue

Dates

Created:: 21/Aug/12 7:39 AM

Updated:: 30/Sep/13 9:07 PM

Resolved:: 15/Sep/12 10:38 AM

Fix Release Date:: 12/Nov/12