Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34984

.form-shortname shouldn't be inside the form label in adminsettings

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. As admin, go to 'debugging' setting (site admin > developmen > debugging)
      2. use firebug to view the source for 'debug messages' and 'debug' for the selection options.

      It should be displayed as :

      <div class="form-label">
      		 
          <label for="id_s__debug">Debug messages</label>
      		 
          <span class="form-shortname">debug</span>
      		 
      </div>

      Show
      As admin, go to 'debugging' setting (site admin > developmen > debugging) use firebug to view the source for 'debug messages' and 'debug' for the selection options. It should be displayed as : <div class="form-label"> <label for="id_s__debug">Debug messages</label> <span class="form-shortname">debug</span> </div>
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      In adminsettings forms the div.form-label contains both the <label> and a span.form-shortname. The span is not actually part of the label text and so should be placed outside of the label tag e.g current:

      <div class="form-item clearfix" id="admin-debug">
      		 
        <div class="form-label">
      		 
          <label for="id_s__debug">Debug messages<span class="form-shortname">debug</span></label>
      		 
        </div>

      should be

      <div class="form-item clearfix" id="admin-debug">
      		 
        <div class="form-label">
      		 
          <label for="id_s__debug">Debug messages</label>
      		 
          <span class="form-shortname">debug</span>
      		 
        </div>

      Otherwise the browser will run both bits of text together to generate a label similar to "Debug messagesdebug" or " Display debug messagesdebugdisplay".

        Attachments

          Activity

            People

            • Assignee:
              rwijaya Rossiani Wijaya
              Reporter:
              bawjaws David Scotson
              Peer reviewer:
              Ankit Agarwal
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Nov/12