Moodle
  1. Moodle
  2. MDL-34989

Overridden assignment grade prevents user submissions.

    Details

    • Rank:
      43575

      Description

      If you have an assign item, and you override a grade in the gradebook, the student becomes unable to make any submissions.

      This is non-intuitive, and not consistent with the behavior in 2.2

        Issue Links

          Activity

          Hide
          Eric Merrill added a comment -

          The patch in MDL-33645 took an over-agressive stance to the problem. The method used to prevent teachers from entering a grade also prevents the student from submitting.

          I hope this wasn't intentional, as it prevents certain use cases.

          Show
          Eric Merrill added a comment - The patch in MDL-33645 took an over-agressive stance to the problem. The method used to prevent teachers from entering a grade also prevents the student from submitting. I hope this wasn't intentional, as it prevents certain use cases.
          Hide
          Damyon Wiese added a comment - - edited

          The current fix for teachers makes the grade field readonly but provides no information on why it is readonly.

          I think teachers should see the link: "Overridden" (title = "Overridden in gradebook") which should be a link to the gradebook. (Alternatives welcome!)

          Students should be able to change their submission if the grade is overridden in the gradebook, but not if it is locked in the gradebook.

          Show
          Damyon Wiese added a comment - - edited The current fix for teachers makes the grade field readonly but provides no information on why it is readonly. I think teachers should see the link: "Overridden" (title = "Overridden in gradebook") which should be a link to the gradebook. (Alternatives welcome!) Students should be able to change their submission if the grade is overridden in the gradebook, but not if it is locked in the gradebook.
          Hide
          Kris Stokking added a comment -

          Damyon - I'm not sure where the current fix is located, but I'd agree with your comment. Is there any chance we can push this fix through the process?

          Show
          Kris Stokking added a comment - Damyon - I'm not sure where the current fix is located, but I'd agree with your comment. Is there any chance we can push this fix through the process?
          Hide
          Michael de Raadt added a comment -

          As this is somewhat of a regression, I'm bumping the issue and assigning it to Ankit, who was involved in the original issue.

          Show
          Michael de Raadt added a comment - As this is somewhat of a regression, I'm bumping the issue and assigning it to Ankit, who was involved in the original issue.
          Hide
          Ankit Agarwal added a comment -

          This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

          For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

          Show
          Ankit Agarwal added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment
          Hide
          Ashley Holman added a comment -

          I've developed a patch which implements the solution suggested by Damyon:

          • Students can still submit if their grade is overridden, but not if it is locked.
          • Teachers who are unable to grade due to locked/overridden grades will see some text which informs them of why they can't grade the submission.
          Show
          Ashley Holman added a comment - I've developed a patch which implements the solution suggested by Damyon: Students can still submit if their grade is overridden, but not if it is locked. Teachers who are unable to grade due to locked/overridden grades will see some text which informs them of why they can't grade the submission.
          Hide
          Damyon Wiese added a comment -

          Thanks for the patch Ash,

          It looks good - there is a conflict on master - I resolved it and updated the tracker and was about the push for integration, but I spotted a missing setType on the grade element as well. ($mform->addElement('hidden', 'grade', $name)

          If you haven't updated this by next week - I'll fix that issue and push it for integration then.

          Show
          Damyon Wiese added a comment - Thanks for the patch Ash, It looks good - there is a conflict on master - I resolved it and updated the tracker and was about the push for integration, but I spotted a missing setType on the grade element as well. ($mform->addElement('hidden', 'grade', $name) If you haven't updated this by next week - I'll fix that issue and push it for integration then.
          Hide
          Damyon Wiese added a comment -

          I updated the patch - instead of changing the function I inlined the only valid check into submissions_open. Otherwise the API does not make sense going back to stables.

          Show
          Damyon Wiese added a comment - I updated the patch - instead of changing the function I inlined the only valid check into submissions_open. Otherwise the API does not make sense going back to stables.
          Hide
          Sam Hemelryk added a comment -

          Pre-integration review: there is a conflict on the 24 branch that's been commit guys - could you please tidy that up for next week.

          Show
          Sam Hemelryk added a comment - Pre-integration review: there is a conflict on the 24 branch that's been commit guys - could you please tidy that up for next week.
          Hide
          Sam Hemelryk added a comment -

          Please please please tidy up the conflict on the MOODLE_24_BRANCH. This is perfect otherwise. I'll leave it in integration review in progress rather than reopening so that it doesn't get delayed.

          Many thanks
          Sam

          Show
          Sam Hemelryk added a comment - Please please please tidy up the conflict on the MOODLE_24_BRANCH. This is perfect otherwise. I'll leave it in integration review in progress rather than reopening so that it doesn't get delayed. Many thanks Sam
          Hide
          Damyon Wiese added a comment -

          Hi Sam - I checked - but it is not conflicting for me - can you look again please?

          Thanks!

          Show
          Damyon Wiese added a comment - Hi Sam - I checked - but it is not conflicting for me - can you look again please? Thanks!
          Hide
          Damyon Wiese added a comment -

          Found it - thanks Sam. I re-pushed the 24 branch.

          Show
          Damyon Wiese added a comment - Found it - thanks Sam. I re-pushed the 24 branch.
          Hide
          Sam Hemelryk added a comment -

          Cool thanks Damyon - this has been integrated now.

          Show
          Sam Hemelryk added a comment - Cool thanks Damyon - this has been integrated now.
          Hide
          Jérôme Mouneyrac added a comment - - edited

          argh... jira shortcut automatically assigned this to me... back assigned to ashley.

          Show
          Jérôme Mouneyrac added a comment - - edited argh... jira shortcut automatically assigned this to me... back assigned to ashley.
          Hide
          Jérôme Mouneyrac added a comment -

          master, 2.5, 2.4, all good, thanks.

          Show
          Jérôme Mouneyrac added a comment - master, 2.5, 2.4, all good, thanks.
          Hide
          Sam Hemelryk added a comment -

          Huzzah, your code made it into Moodle. Perhaps now things are ever so slightly better!

          "The ship can't take this much pressure. Sometimes it falls apart just sitting in the hangar."
          ~ Professor Farnsworth

          Show
          Sam Hemelryk added a comment - Huzzah, your code made it into Moodle. Perhaps now things are ever so slightly better! "The ship can't take this much pressure. Sometimes it falls apart just sitting in the hangar." ~ Professor Farnsworth

            People

            • Votes:
              4 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: