[MDL-34990] Add custom toolbar setting validation - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_24_STABLE
Fixed Branches:
MOODLE_24_STABLE
Pull from Repository:
git://github.com/skodak/moodle.git
Pull Master Branch:
w35_~~MDL-34990~~_m24_tinymcebuttonsfix
Pull Master Diff URL:
https://github.com/skodak/moodle/compare/w35_MDL-34879_m24_tinymcedocs...w35_MDL-34990_m24_tinymcebuttonsfix
Testing Instructions:

Hide

1/ Run phpunit tests. (tests have been added to test the fix)
2/ Try any randomly formatted list of buttons in customtoolbar setting. (This should test for any possible situation/sequence that the fix/unittests haven't picked up on)

see https://github.com/skodak/moodle/blob/b3aefe3cc85bc9c941449c1f10ff9fce02b57a5d/lib/editor/tinymce/lib.php#L156 for some buttons

Show
1/ Run phpunit tests. (tests have been added to test the fix) 2/ Try any randomly formatted list of buttons in customtoolbar setting. (This should test for any possible situation/sequence that the fix/unittests haven't picked up on) see https://github.com/skodak/moodle/blob/b3aefe3cc85bc9c941449c1f10ff9fce02b57a5d/lib/editor/tinymce/lib.php#L156 for some buttons

The problem is that invalid csv formatted list of buttons may cause JS errors in TinyMCE. Solution is to treat all invalid characters as separators.

has a non-specific relationship to

MDL-34878 Basic setting for customisation of editor buttons

is blocked by

MDL-34879 Write new tinymce subplugin developer docs

Participants:: Aparup Banerjee, Eloy Lafuente (stronk7), Petr Skoda, Rossiani Wijaya

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo