Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34991

comments entered via comments API when sent to messaging as notification: viewing them in message/index.php?viewing=recentnotifications does not convert CRLF to html br tag.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.1, 2.4
    • Fix Version/s: 2.4
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide

      1) this requires a moodle plugin that will send out notifications (with multiple lines, '\n'). In my case here i've here the plugins DB where i'm attempting to do this.

      2) but really all we need to do to test this is :
      a) test that messaging of notifications still work fine. One way is via mod forum post notifications (/mod/forum/lib.php:714: $eventdata->notification = 1; ). so you can play around with that, perhaps add multiple lines to that notification and see that they render fine in the messaging notifications page (message/index.php?viewing=recentnotifications).

      b) test that no malicious scripts can get through to any user via any of the messaging processors ( jabber, email, and we've tested the webui in (a) so we can trust core there )

      Show
      1) this requires a moodle plugin that will send out notifications (with multiple lines, '\n'). In my case here i've here the plugins DB where i'm attempting to do this. 2) but really all we need to do to test this is : a) test that messaging of notifications still work fine. One way is via mod forum post notifications (/mod/forum/lib.php:714: $eventdata->notification = 1; ). so you can play around with that, perhaps add multiple lines to that notification and see that they render fine in the messaging notifications page (message/index.php?viewing=recentnotifications). b) test that no malicious scripts can get through to any user via any of the messaging processors ( jabber, email, and we've tested the webui in (a) so we can trust core there )
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      While working on MDLSITE-1427 : notifications (part of which were the comment from plugin comments ) were being renderered before converting text to html.

      The patch here should now allow notifications to be formatted by text_to_html() which is called from within format_text().

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/12