unordered message providers settings options list thingy.

patched - up for peer-review/feedback.
Edit: should be easy backport.

Whats the reason for sorting by array element then by array key? It seems like doing the second sort is going to make the first sort pointless...

ah, it sorts the values then the keys , in this way hoping the values have some sequence too once the keys are sequenced. i thought it did that from a quick check.

If it all seems to work go ahead and submit it for integration

up for further scrutiny.

nb: could be made a little better by providing a grouping in the form based on component_*

Is this going to change the interface?

hrm strictly speaking , yes the ui does change. However, its a simple re-ordering of rows of checkboxes - so functionally no ui_change. its rather a aesthetic ui change. tag it so if you want to be safe

I think it should sort by component and then group them with headings.

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

reopening: in the midst of adding groupings

Adding the ui_change label. This sounds like it will be notable in the release notes.

ok, grouped into components.
It was a really long list of tables so i made them float (see screenshot)
i'd like to make the provider name span nicely without making the tables seems different widths but got no ideas there so submitting for peer-review

ps: note that i've moved the 'disable notifications' setting into under 'general' field set as it seems not so cluttered then and actually seems to belong in general too.

This solution may be effective only for admin who can see all providers. Ordinary users can't see providers that are constrained by capability in module context (and possibly in course context). See MDL-35582. Generating the providers list for all context levels per the given user may be extremely expensive so the ui should probably include designated navigation/filter for displaying providers by context.

Thanks for looking at this Itamar.
You're patch in MDL-35582 seems to be headed in the correct direction from a glance but i'll let Andrew review it there.
I understand that this doesn't affect this patch being integrated as this is about aesthetics.

[Y] Syntax
[Y] Output
[N] Whitespace
[Y] Language
[Y] Databases
[N] Testing
[Y] Security
[NA] Documentation
[N] Git
[Y] Sanity check

"$table->data = array();"
line 244 appears to be overly indentified.

The component in your commit messages is inconsistent and incorrect in both cases. I believe it should be core_message.

In the testing instructions include a summary of how the grouping should work. I'd also include actually getting the tester to modify their settings just to make absolutely sure its all fine.

All pretty minor.

Thanks for that check(list) Andrew
i've cleaned up line 244 as well as 250's indents.
i've gone with 'message' as the code area which is prevalent from commit logs. (i saw 'core_message' only in AMOS commands)

sending this to integrators.

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Hi Apu,

Reopening this sorry dude, there was just one thing that I spotted in this code that is a problem.
The sorting of components in renderer.php breaks horribly as soon as you have an admin tool, theme, or any other plugin with a component starting with a letter greater than M that also has a messages.php.
The code removes the last plugin and adds Moodle back instead leading to the system settings being shown twice (Simple way to reproduce is to add a messages.php file to an admin tool).
Potentially you could argue that we don't have any such plugins in core that have a messages.php file, however I could imagine admin tools in particular sending messages and I think that use case is pretty strong and that we should clean this up now while we are aware of it.

Perhaps while you're there any way you wouldn't mind cleaning up the underscore in $number_procs, I see it was there originally, however there is just its initialisation and a single use both lines that you've modified so would be a good time to clean it up.

Many thanks
Sam

Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

thanks for that catch Sam. cleaning that up now..

That dodgy sorting has been reduced by one array action now. Code cleaned up as suggested too.
Appended test to include various plugins with db/messages.php if possible.

All yours

Thanks Apu, has been integrated now

Tested this in 2.4 only.

This works as expected.

Test passed.

From somewhere within the clouds...

Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!

Ciao

Removing docs_required label as this is documented here http://docs.moodle.org/24/en/Messaging_settings