Moodle
  1. Moodle
  2. MDL-34993

Default mark 1 when editing MC questions should not be displayed as 1.0000000

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2, 2.3.1, 2.4
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Questions
    • Labels:
      None
    • Testing Instructions:
      Hide

      1. Create a question.

      2. Edit the question again. Make sure the Default mark field contains 1, and no 1.0000000.

      3. Change the default mark to 1.2345678, and make sure that fits in the box.

      Show
      1. Create a question. 2. Edit the question again. Make sure the Default mark field contains 1, and no 1.0000000. 3. Change the default mark to 1.2345678, and make sure that fits in the box.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      43581

      Description

      When editing a multichoice question the default mark 1 is displayed as 1.0000000 (see screenshot)
      This is due to storing the mark as NUMBER(12,7)in the DB. It would be nice if such a default mark would
      be displayed as '1' in the future.
      Tim Hunt knows the issue and suggests that "You just need to add +0 in the code that passes the value to the form.".

        Activity

        Hide
        Tim Hunt added a comment -

        Thanks Juergen. Fix submitted for integration.

        Show
        Tim Hunt added a comment - Thanks Juergen. Fix submitted for integration.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (22, 23 & master), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (22, 23 & master), thanks!
        Hide
        Adrian Greeve added a comment -

        Tested in 2.2, 2.3 and master.
        The default mark now stays at 1 and not 1.000000
        Numbers that are longer than 9 characters are rounded up or down.
        Test passed.

        Show
        Adrian Greeve added a comment - Tested in 2.2, 2.3 and master. The default mark now stays at 1 and not 1.000000 Numbers that are longer than 9 characters are rounded up or down. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        I'm so proud...of you, many thanks!

        http://youtu.be/n64CdfDRnZY

        Closing as fixed, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - I'm so proud...of you, many thanks! http://youtu.be/n64CdfDRnZY Closing as fixed, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: