Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35003

Quiz results displaying an extra full stop

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2, 2.3.1, 2.4
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      0. Purge all caches, to force lang string renewal.

      1. Create a short-answer question with the correct answer "The cat sat on the mat.". Note the . included in that answer.

      2. Preview this question. Make sure the Right answer
      display option is set to shown, if not, turn it on and Start again with these options.

      3. Type in any answer, and submit all and finish.

      4. Verify that the feedback includes "The correct answer is: The cat sat on the mat.". (Previously, it would have been "The cat sat on the mat..")

      Rinse and repeat for a numerical and a matching question.

      Show
      0. Purge all caches, to force lang string renewal. 1. Create a short-answer question with the correct answer "The cat sat on the mat.". Note the . included in that answer. 2. Preview this question. Make sure the Right answer display option is set to shown, if not, turn it on and Start again with these options. 3. Type in any answer, and submit all and finish. 4. Verify that the feedback includes "The correct answer is: The cat sat on the mat.". (Previously, it would have been "The cat sat on the mat..") Rinse and repeat for a numerical and a matching question.
    • Workaround:
      Hide

      Turn off the 'Correct answer' review option in the quiz, and instead explain the correct response in your own words as part of the General Feedback.

      Show
      Turn off the 'Correct answer' review option in the quiz, and instead explain the correct response in your own words as part of the General Feedback.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      When displaying the feedback to students, the correct answer field is appending a full stop. Whilst this may be aesthetically pleasing to some, it can be confusing when punctuation is critical in a response. It also creates nonsensical feedback when a response already containes a full stop, ie. the correct answer field will have two.

      eg.
      Student Answer: Smith, J. (1998). Ecology today. Nature, 8(1), 25-45.
      Moodle Response: Smith, J. (1998). Ecology today. Nature, 8(1), 25-45..

      eg2.
      The correct answer is: ABC News Online. (2008, November 4). ABC News Outline. Retrieved November 4, 2008, from http://www.abc.net.au/news/etc.
      The full stop at the end of a web address is incorrect. A student who heeded this feedback, then applied it in a referencing activity would be marked incorrect.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            timhunt Tim Hunt added a comment -

            Related forum discussion: http://moodle.org/mod/forum/discuss.php?d=208360

            The suggestion is to change this string back to how it was in 1.9:

            Correct answer: {$a}

            rather than trying to make it a gramatically correct sentence.

            Show
            timhunt Tim Hunt added a comment - Related forum discussion: http://moodle.org/mod/forum/discuss.php?d=208360 The suggestion is to change this string back to how it was in 1.9: Correct answer: {$a} rather than trying to make it a gramatically correct sentence.
            Hide
            timhunt Tim Hunt added a comment -

            To INTEGRATORS: do I need to bump version.php because of this string change?

            Show
            timhunt Tim Hunt added a comment - To INTEGRATORS: do I need to bump version.php because of this string change?
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Tim, surely for upstream is not necessary to bump version, because we do that weekly before rolling... but for testing it may be recommended (unless the tester has lang strings caching disabled), or you should encourage to purge caches in such instructions (I'm adding that point to them).

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Tim, surely for upstream is not necessary to bump version, because we do that weekly before rolling... but for testing it may be recommended (unless the tester has lang strings caching disabled), or you should encourage to purge caches in such instructions (I'm adding that point to them). Ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated (22, 23 & master), thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (22, 23 & master), thanks!
            Hide
            timhunt Tim Hunt added a comment -

            Thanks Eloy.

            Show
            timhunt Tim Hunt added a comment - Thanks Eloy.
            Hide
            abgreeve Adrian Greeve added a comment -

            Tested in 2.2, 2.3 and master.
            Only one full stop is now being displayed.
            No errors encountered.
            Test passed.

            Show
            abgreeve Adrian Greeve added a comment - Tested in 2.2, 2.3 and master. Only one full stop is now being displayed. No errors encountered. Test passed.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            I'm so proud...of you, many thanks!

            http://youtu.be/n64CdfDRnZY

            Closing as fixed, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - I'm so proud...of you, many thanks! http://youtu.be/n64CdfDRnZY Closing as fixed, ciao
            Hide
            jbloggs Adam Barbary added a comment -

            Thanks guys.

            Show
            jbloggs Adam Barbary added a comment - Thanks guys.

              People

              • Votes:
                3 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Sep/12