Moodle
  1. Moodle
  2. MDL-35010

Missing fieldset in edit sections form

    Details

    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Navigate to Site admin > Advanced features
      3. Check "Enable conditional access" (enableavailability)
      4. Check "Enable group members only" (enablegroupmembersonly)
      5. Navigate to a course
      6. Edit a section in the middle of the course
      7. TEST: Verify all the availability conditions are enclosed with one "Restrict access" fieldset.
      8. Uncheck "Enable group members only" (enablegroupmembersonly)
      9. TEST: Verify all the availability conditions are enclosed with one "Restrict access" fieldset.

      That is.

      Show
      Log in as admin Navigate to Site admin > Advanced features Check "Enable conditional access" (enableavailability) Check "Enable group members only" (enablegroupmembersonly) Navigate to a course Edit a section in the middle of the course TEST: Verify all the availability conditions are enclosed with one "Restrict access" fieldset. Uncheck "Enable group members only" (enablegroupmembersonly) TEST: Verify all the availability conditions are enclosed with one "Restrict access" fieldset. That is.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      43610

      Description

      Testing MDL-34444 discovered this.

      The "Restrict access" fieldset is not shown always in the edit section form (23 & master).

      The reason is that this line:

      $mform->addElement('header', '', get_string('availabilityconditions', 'condition'));
      

      is incorrectly under one $CFG->enablegroupmembersonly condition. Moving the line out from that condition should lead to the fieldset being rendered always.

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Marshall added a comment -

          +1 from me, dunno why this was broken...

          Show
          Sam Marshall added a comment - +1 from me, dunno why this was broken...
          Hide
          Aparup Banerjee added a comment -

          thanks, thats tested and integrated into 23 and master.

          (no blocks on this section edit seemed a little blank imo)

          Show
          Aparup Banerjee added a comment - thanks, thats tested and integrated into 23 and master. (no blocks on this section edit seemed a little blank imo)
          Hide
          Aparup Banerjee added a comment -

          passed!

          Show
          Aparup Banerjee added a comment - passed!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          I'm so proud...of you, many thanks!

          http://youtu.be/n64CdfDRnZY

          Closing as fixed, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - I'm so proud...of you, many thanks! http://youtu.be/n64CdfDRnZY Closing as fixed, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: