Moodle
  1. Moodle
  2. MDL-35027

Hidden forum's subscribers list shows participants with no access to forum

    Details

    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_27_STABLE

      Description

      If a forum is set to be restricted to only users with the teacher role, the students can't see the forum. That works fine. But if the forum is set to "Auto subscription", then all the course participants gets on the subscribers list and get mail, then the teachers are posting in the hidden forum.
      This is quite surprising for the teacher...
      The subscribers list should accurately reflect the participants who can access the forum.

      Replication steps:

      1. Log in as admin/teacher
      2. Navigate to a course that has students and teachers enrolled.
      3. Create a forum
        • set the subscription mode to Auto subscription
        • set the visibility to hidden
        • click Save and display
      4. Navigate to Settings > Forum admin > Show/edit current subscribers

      Expected result: Users unable to view the forum should be absent/separate/differentiated.

      Actual result: All enrolled users are subscribed and displayed in the same way.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Michael de Raadt added a comment -

            Hi.

            It is true that when a forum is created using 'Auto subscribe', all enrolled users will be subscribed to the forum (including later enrolments).

            However, messages are not sent to people who are not able to see the forum when it is hidden. Here is the result of running cron manually to process a post in a forum that is hidden...

            Processing module function forum_cron ...Processing user 3
            user 3 can not see 10
            Processing user 4
            user 4 can not see 10
            Processing user 5
            user 5 can not see 10
            Processing user 15
            Sending post 10: Another post
            1 users were sent post 10, 'Another post'
            

            So I'm confident that the messages being sent match the visibility of the forum at the time the messages are being sent.

            Show
            Michael de Raadt added a comment - Hi. It is true that when a forum is created using 'Auto subscribe', all enrolled users will be subscribed to the forum (including later enrolments). However, messages are not sent to people who are not able to see the forum when it is hidden. Here is the result of running cron manually to process a post in a forum that is hidden... Processing module function forum_cron ...Processing user 3 user 3 can not see 10 Processing user 4 user 4 can not see 10 Processing user 5 user 5 can not see 10 Processing user 15 Sending post 10: Another post 1 users were sent post 10, 'Another post' So I'm confident that the messages being sent match the visibility of the forum at the time the messages are being sent.
            Hide
            Per Hessellund Laursen added a comment -

            Hi Michael,
            That's nice to know that the sending of mail respect the user role. But I still think that the subscribers list should match the mailing list. It makes no sense that the subscribers list don't show who will get the message by mail. What else is the list good for?
            Actually it gave me a huge chock to see subscribers list
            BR Per

            Show
            Per Hessellund Laursen added a comment - Hi Michael, That's nice to know that the sending of mail respect the user role. But I still think that the subscribers list should match the mailing list. It makes no sense that the subscribers list don't show who will get the message by mail. What else is the list good for? Actually it gave me a huge chock to see subscribers list BR Per
            Hide
            Michael de Raadt added a comment -

            The problem is that the visibility of the activity can change over time. If you were to hide and then unhide the forum, you would loose the subscription information. I think this needs to be the case.

            What could help improve this would be to show more accurate information on the subscribers list page. Perhaps users who are subscribed but cannot see the forum should be displayed separately or in a different way. I will alter this issue to that effect.

            Show
            Michael de Raadt added a comment - The problem is that the visibility of the activity can change over time. If you were to hide and then unhide the forum, you would loose the subscription information. I think this needs to be the case. What could help improve this would be to show more accurate information on the subscribers list page. Perhaps users who are subscribed but cannot see the forum should be displayed separately or in a different way. I will alter this issue to that effect.
            Hide
            Kevin Wiliarty added a comment -

            In my testing I find that this bug, while still affecting the 2.7 branch, has been fixed in 2.8 and 2.9dev.

            Show
            Kevin Wiliarty added a comment - In my testing I find that this bug, while still affecting the 2.7 branch, has been fixed in 2.8 and 2.9dev.

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: