[MDL-35027] Hidden forum's subscribers list shows participants with no access to forum - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.2.4, 2.3.2, 2.7.4, 2.8.7, 2.9, 3.0
Fix Version/s: 2.8.8, 2.9.2
Component/s: Forum, Roles / Access
Labels:
- ci
- triaged
- ui_change

Affected Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
Fixed Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE
Pull from Repository:
https://github.com/bostelm/moodle.git
Pull Main Branch:
~~MDL-35027~~-B
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...bostelm:MDL-35027-B
Testing Instructions:
Hide

Prerequisites: A course with a teacher (T) and a student (S) enrolled.

Create a forum in the course and set its subscription mode to "forced subscription". The forum should be set to "Visible: Show".

Go to the forum and click "Show/edit current subscribers".

VERIFY: Both T and S are shown in the list.

VERIFY: There is no button "Turn editing on" on the top-right of the page.

Go to "Forum administration -> Edit settings" and set the forum to "Visible: Hide".

Go to the forum and click "Show/edit current subscribers".

VERIFY: Only T is shown in the list (not S).

VERIFY: There is no button "Turn editing on" on the top-right of the page.
Show
Prerequisites: A course with a teacher (T) and a student (S) enrolled. Create a forum in the course and set its subscription mode to "forced subscription". The forum should be set to "Visible: Show". Go to the forum and click "Show/edit current subscribers". VERIFY: Both T and S are shown in the list. VERIFY: There is no button "Turn editing on" on the top-right of the page. Go to "Forum administration -> Edit settings" and set the forum to "Visible: Hide". Go to the forum and click "Show/edit current subscribers". VERIFY: Only T is shown in the list (not S). VERIFY: There is no button "Turn editing on" on the top-right of the page.

Description

If a forum is set to be restricted to only users with the teacher role, the students can't see the forum. That works fine. But if the forum is set to "Forced subscription", then all the course participants are included in the subscribers list (mod/forum/subscribers.php).

This is quite surprising for the teacher. Mailings do not actually go out to users who can't see the forum, but the teachers gets the impression that they do.

The subscribers list should accurately reflect the participants who can access the forum.

Replication steps:

Log in as admin/teacher
Navigate to a course that has students and teachers enrolled.
Create a forum
- set the subscription mode to Forced subscription
- set the visibility to hidden
- click Save and display
Navigate to Settings > Forum admin > Show/edit current subscribers

Expected result: Users unable to view the forum should be absent/separate/differentiated.

Actual result: All enrolled users are subscribed and displayed in the same way.

Attachments

Issue Links

has a non-specific relationship to

MDL-33166 Add forum capability "mod/forum:allowforcesubscribe" or restore "mod/forum:initialsubscriptions"

Closed

MDL-50857 In subscribers list, indicate whether the forum is hidden for a subscriber

Closed

has been marked as being related by

MDL-48625 Function to filter list of users who can see the activity

Closed

Activity

People

Assignee:: Henning Bostelmann

Reporter:: Per Hessellund Laursen

Peer reviewer:: Simey Lameze

Integrator:: Eloy Lafuente (stronk7)

Tester:: Damyon Wiese

Participants:: Andrew Lyons, CiBoT, Damyon Wiese, Eloy Lafuente (stronk7), Henning Bostelmann, Kevin Wiliarty, Michael de Raadt, Per Hessellund Laursen, Rex Lorenzo, Simey Lameze

Votes:: 2 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 23/Aug/12 10:26 PM

Updated:: 06/Aug/15 11:55 PM

Resolved:: 06/Aug/15 11:11 PM

Fix Release Date:: 14/Sep/15