Moodle
  1. Moodle
  2. MDL-35037

After disabling blogging, blog links are still shown on tags pages

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.1, 2.4.1, 2.5
    • Fix Version/s: 2.3.5, 2.4.2
    • Component/s: Blog, Tags
    • Labels:
    • Testing Instructions:
      Hide

      In master & 24:

      1. Go to Home ▶ Site administration ▶ Advanced features
      2. Ensure blogs are enabled
      3. Go to Home ▶ My profile ▶ Blogs ▶ Add a new entry
      4. Add a blog entry, ensuring you add a tag of: starfish
      5. Go to http://yourmoodle/tag/index.php?tag=starfish
      6. VERIFY: you can see the post you created
      7. Go to Home ▶ Site administration ▶ Advanced features
      8. Disable blogs.
      9. VERIFY: you can no longer see blog posts.

      In 23:

      1. Go to Home ▶ Site administration ▶ Advanced features
      2. Ensure blogs visibility is 'All users can see all blog entries'
      3. Go to Home ▶ My profile ▶ Blogs ▶ Add a new entry
      4. Add a blog entry, ensuring you add a tag of: starfish
      5. Go to http://yourmoodle/tag/index.php?tag=starfish
      6. VERIFY: you can see the post you created
      7. Go to Home ▶ Site administration ▶ Advanced features
      8. Ensure blogs visibility is 'Disable blog system completely'
      9. VERIFY: you can no longer see blog posts.
      Show
      In master & 24: Go to Home ▶ Site administration ▶ Advanced features Ensure blogs are enabled Go to Home ▶ My profile ▶ Blogs ▶ Add a new entry Add a blog entry, ensuring you add a tag of: starfish Go to http://yourmoodle/tag/index.php?tag=starfish VERIFY: you can see the post you created Go to Home ▶ Site administration ▶ Advanced features Disable blogs. VERIFY: you can no longer see blog posts. In 23: Go to Home ▶ Site administration ▶ Advanced features Ensure blogs visibility is 'All users can see all blog entries' Go to Home ▶ My profile ▶ Blogs ▶ Add a new entry Add a blog entry, ensuring you add a tag of: starfish Go to http://yourmoodle/tag/index.php?tag=starfish VERIFY: you can see the post you created Go to Home ▶ Site administration ▶ Advanced features Ensure blogs visibility is 'Disable blog system completely' VERIFY: you can no longer see blog posts.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull 2.4 Branch:
    • Pull Master Branch:
    • Rank:
      43648

      Description

      Blogging was previously enabled on moodle.org but is now disabled. Blog links are still shown on tags pages though, for example http://moodle.org/tag/index.php?tag=about%20me

        Activity

        Hide
        Michael de Raadt added a comment -

        I can't see any there, Helen.

        Where should I be looking? How could we reproduce this?

        Show
        Michael de Raadt added a comment - I can't see any there, Helen. Where should I be looking? How could we reproduce this?
        Hide
        Helen Foster added a comment -

        Hmm, it seems that blog links are only shown to admins and when using guest access - see attached screen shots.

        Show
        Helen Foster added a comment - Hmm, it seems that blog links are only shown to admins and when using guest access - see attached screen shots.
        Hide
        Martin Dougiamas added a comment -

        Confirmed. I see this too (as me and guest)

        Show
        Martin Dougiamas added a comment - Confirmed. I see this too (as me and guest)
        Hide
        Dan Poltawski added a comment -

        Simple fix which i've submitting for integration.

        Show
        Dan Poltawski added a comment - Simple fix which i've submitting for integration.
        Hide
        Dan Poltawski added a comment -

        blog_listing is at least checking the visibility level of the results returned.

        Show
        Dan Poltawski added a comment - blog_listing is at least checking the visibility level of the results returned.
        Hide
        Damyon Wiese added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        Cheers!

        Show
        Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Cheers!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (23, 24 & master), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (23, 24 & master), thanks!
        Hide
        Adrian Greeve added a comment -

        Tested on the 2.3, 2.4 and master integration branches.
        I verified that posts were visible or no longer visible depending on the admin settings.
        Test passed.

        Show
        Adrian Greeve added a comment - Tested on the 2.3, 2.4 and master integration branches. I verified that posts were visible or no longer visible depending on the admin settings. Test passed.
        Hide
        Damyon Wiese added a comment -

        Congratulations this fix has been added to Moodle!

        You may want to dedicate this issue to someone special on this Valentines day.

        Thanks!

        Show
        Damyon Wiese added a comment - Congratulations this fix has been added to Moodle! You may want to dedicate this issue to someone special on this Valentines day. Thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: