Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35042

Allow HTML block instances advanced setting to be toggled

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Blocks
    • Labels:
    • Testing Instructions:
      Hide

      Create a new course.
      Add multiple HTML blocks with titles and content. Note that there is no config for specifying CSS classes.
      Inspect each of the block's CSS class values in their outer divs (should be something like "block_html block")
      Go to Admin -> Plugins -> Blocks -> HTML, and enable "Allow additional CSS classes"
      Go back to course and in each block add some values to the "Additional CSS classes" fields and save.
      Inspect each of the block's CSS class values again and the classes specified in the previous step should be appended to the original classes.
      Go to Admin -> Plugins -> Blocks -> HTML, and disable "Allow additional CSS classes"
      Inspect each of the block's CSS class values in their outer divs (additional configured classes should no longer be added)
      Each block's settings form should no longer have the "Additional CSS classes" field.

      Show
      Create a new course. Add multiple HTML blocks with titles and content. Note that there is no config for specifying CSS classes. Inspect each of the block's CSS class values in their outer divs (should be something like "block_html block") Go to Admin -> Plugins -> Blocks -> HTML, and enable "Allow additional CSS classes" Go back to course and in each block add some values to the "Additional CSS classes" fields and save. Inspect each of the block's CSS class values again and the classes specified in the previous step should be appended to the original classes. Go to Admin -> Plugins -> Blocks -> HTML, and disable "Allow additional CSS classes" Inspect each of the block's CSS class values in their outer divs (additional configured classes should no longer be added) Each block's settings form should no longer have the "Additional CSS classes" field.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      MDL-34899 introduced a new setting for HTML block instances allowing them to set custom additional CSS classes. This could be confusing to administrators so I have created a site-wide setting to enable/disable their use (and defaulted them to be off).

      When the setting is disabled, the form setting ceases to appear and any previously set values are no longer honoured (however they are saved in the database and will be honoured again if the setting is re-enabled).

        Attachments

          Issue Links

          has been marked as being related by

          New Feature - A new Moodle feature which has yet to be developed. MDL-34899 Allow HTML block instances to specify additional CSS classes

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              sry_not4sale Aaron Barnes
              Reporter:
              sry_not4sale Aaron Barnes
              Peer reviewer:
              Frédéric Massart Frédéric Massart
              Integrator:
              Aparup Banerjee Aparup Banerjee
              Tester:
              Ankit Agarwal Ankit Agarwal
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Dec/12