Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35047

Missing strings in xmldb editor

    Details

    • Testing Instructions:
      Hide
      1. login as admin
      2. goto xmldb editor (Site administration -> Development -> XMLDB editor)
      3. load and edit any table (Click on load and then edit will appear)
      4. In Tables section click on edit
      5. Click on "New index", and click "change"
      6. Make sure all strings are fine and no php notice/error is encountered.
      7. Try above with some proper field name and ensure proper strings are visible, without php notice/error.
      Show
      login as admin goto xmldb editor (Site administration -> Development -> XMLDB editor) load and edit any table (Click on load and then edit will appear) In Tables section click on edit Click on "New index", and click "change" Make sure all strings are fine and no php notice/error is encountered. Try above with some proper field name and ensure proper strings are visible, without php notice/error.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      wip-mdl-35047

      Description

      Replication steps:

      1. login as admin
      2. goto xmldb editor
      3. load and edit any table
      4. try to add a index , use name of any existing field as the name for index.

      Expected result: Shows a error that the name is already being used

      Actual result: Missing string exceptions are thrown

      Invalid get_string() identifier: 'indexnameempty' or component 'tool_xmldb'. Perhaps you are missing $string['indexnameempty'] = ''; in /var/www/stable/master/moodle/admin/tool/xmldb/lang/en/tool_xmldb.php?
       
          line 6640 of /lib/moodlelib.php: call to debugging()
          line 7264 of /lib/moodlelib.php: call to core_string_manager->get_string()
          line 137 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to get_string()
          line 53 of /admin/tool/xmldb/actions/edit_index_save/edit_index_save.class.php: call to XMLDBAction->loadStrings()
          line 60 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to edit_index_save->init()
          line 67 of /admin/tool/xmldb/index.php: call to XMLDBAction->__construct()
       
      Invalid get_string() identifier: 'incorrectindexname' or component 'tool_xmldb'. Perhaps you are missing $string['incorrectindexname'] = ''; in /var/www/stable/master/moodle/admin/tool/xmldb/lang/en/tool_xmldb.php?
       
          line 6640 of /lib/moodlelib.php: call to debugging()
          line 7264 of /lib/moodlelib.php: call to core_string_manager->get_string()
          line 137 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to get_string()
          line 53 of /admin/tool/xmldb/actions/edit_index_save/edit_index_save.class.php: call to XMLDBAction->loadStrings()
          line 60 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to edit_index_save->init()
          line 67 of /admin/tool/xmldb/index.php: call to XMLDBAction->__construct()
       
      Invalid get_string() identifier: 'duplicateindexname' or component 'tool_xmldb'. Perhaps you are missing $string['duplicateindexname'] = ''; in /var/www/stable/master/moodle/admin/tool/xmldb/lang/en/tool_xmldb.php?
       
          line 6640 of /lib/moodlelib.php: call to debugging()
          line 7264 of /lib/moodlelib.php: call to core_string_manager->get_string()
          line 137 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to get_string()
          line 53 of /admin/tool/xmldb/actions/edit_index_save/edit_index_save.class.php: call to XMLDBAction->loadStrings()
          line 60 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to edit_index_save->init()
          line 67 of /admin/tool/xmldb/index.php: call to XMLDBAction->__construct()

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/Nov/12