Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34696 enrol improvements 2.4 META
  3. MDL-35071

Redesign enrol restore support

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      This issue requires new QA tests, previously there was not much to test because only restore of manual enrolments worked properly.

      1/ create backups on different sites using different settings and enrolment instances (with/without users)

      2/ verify different restore types (new course, override and add content) with the "Restore as manual enrolments" enabled - it is expected that all enrolments are merged into one manual enrol instance

      3/ verify different restore types (new course, override and add content) with the "Restore as manual enrolments" disabled

      • manual enrolments are restored
      • self enrolments may be merged with existing instances if role matches
      • there is max 1 guest enrol instance
      • all other enrolment types are not supposed to be restored (yet)
      • verify instance sortorder matches the original course

      Note: MDL-27856 implements cohort restore, it could be tested together with this issue.

      Show
      This issue requires new QA tests, previously there was not much to test because only restore of manual enrolments worked properly. 1/ create backups on different sites using different settings and enrolment instances (with/without users) 2/ verify different restore types (new course, override and add content) with the "Restore as manual enrolments" enabled - it is expected that all enrolments are merged into one manual enrol instance 3/ verify different restore types (new course, override and add content) with the "Restore as manual enrolments" disabled manual enrolments are restored self enrolments may be merged with existing instances if role matches there is max 1 guest enrol instance all other enrolment types are not supposed to be restored (yet) verify instance sortorder matches the original course Note: MDL-27856 implements cohort restore, it could be tested together with this issue.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w37_MDL-35071_m24_enrolrestore
    • Pull Master Diff URL:

      Description

      List of solved problems:

      • no way to restore enrolments from disabled/nonexistent/nonrestorable plugins - solution is to add option to "Restore as manual enrolments" options which migrates data to standard enrol_manual plugin
      • no way to map/alter custom fields - such as roles or userid stored in customintX fields
      • roles need to be restored AFTER the enrolments because they need new enrolid
      • enrol->sortorder should be converted to XML field order, we do not need the value in backup file at all
      • support for multiple enrol-self instances
      • trigger automatic sync of all enrol plugins before the restore of first instance - this creates course category enrolments for example, it might trigger LDAP sync, etc.
      • let enrol plugins create instances, enrolments and role assignments - we need as much flexibility as possible, let plugins decide eveything

      Not included in this issue:

      • ability to backup/restore extra tables of enrol plugins
      • only self, manual and guest plugins are fully implemented, the rest will follow if this gets integrated

        Attachments

          Issue Links

          blocks

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-27856 Cohort enrolment restore support

          • Major - Major loss of function, incorrect output
          • Closed

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-35062 Add setting for cron action after enrolment expiration - enrol_self

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-22148 backup: cohorts

          • Major - Major loss of function, incorrect output
          • Closed

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-23875 Option to Limit Self-Enrolment to members of a Cohort

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-26222 Course restore does not restore user roles when enrol plugin is not manual

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-29414 Improve enrol plugins to better handle its unique/multiple property

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-34387 Restore course in 2.3 from a course created in 2.2 reports error in metacourse enrolment

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              skodak Petr Skoda
              Reporter:
              skodak Petr Skoda
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Dec/12