Loading...

XML

Word

Printable

Affected Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE
Fixed Branches:
MOODLE_23_STABLE
Pull from Repository:
git://github.com/stronk7/moodle.git
Pull Main Branch:
~~MDL-35089~~
Pull Main Diff URL:
https://github.com/stronk7/moodle/compare/master...MDL-35089
Difficulty:
Easy
Testing Instructions:
Hide

1) Ensure that both DEBUG_DEVELOPER and display errors are enabled.
2) Run all phpunit tests (23_STABLE and master)
3) TEST: Verify there is not any debugging message (+ stack trace) with:

Debugging: Coding problem - missing course sectioncache property in get_fast_modinfo()

4) TEST: Verify that there is not any failure/exception related with conditions (conditionlib, condition_info_base...) stuff. In fact you should get 100% pass if your DB (mysql, postgres) is properly configured.
Show
1) Ensure that both DEBUG_DEVELOPER and display errors are enabled. 2) Run all phpunit tests (23_STABLE and master) 3) TEST: Verify there is not any debugging message (+ stack trace) with: Debugging: Coding problem - missing course sectioncache property in get_fast_modinfo() 4) TEST: Verify that there is not any failure/exception related with conditions (conditionlib, condition_info_base...) stuff. In fact you should get 100% pass if your DB (mysql, postgres) is properly configured.

This was detected when running PHPUnit tests from command line and is caused by new debugging details added to get_fast_modinfo() by ~~MDL-34936~~.

Along tests execution there are a bunch of message like this (different is_available() call lines):

Debugging: Coding problem - missing course sectioncache property in get_fast_modinfo() call

* line 1208 of /lib/modinfolib.php: call to debugging()

* line 940 of /lib/conditionlib.php: call to get_fast_modinfo()

* line 280 of /lib/conditionlib.php: call to condition_info_base->is_available()

* line 654 of /lib/tests/conditionlib_test.php: call to condition_info_section->is_available()

* line ? of unknownfile: call to conditionlib_testcase->test_section_is_available()

So I bet tests are missing to pass the corresponding sectioninfo to get_fast_modinfo()

Ciao

Discovered while testing

MDL-34936 get_fast_modinfo should throw debug warnings about missing course->sectioncache