Moodle
  1. Moodle
  2. MDL-35092

PayPal enrolments don't support using Moodle's Proxy

    Details

    • Testing Instructions:
      Hide
      • Install Patch
      • Create PayPal Sandbox account or use existing PayPal Business account
      • Configure PayPal to Instant Payment Notification for your site as :-
      • http://moodle.com/enrol/paypal/ipn.php
      • Configure in Site Wide PayPal business email
      • Create a course using PayPal as enrolment method
      • Try enrol as a student
      • Pay via PayPal Sandbox account or any PayPal account
      Show
      Install Patch Create PayPal Sandbox account or use existing PayPal Business account Configure PayPal to Instant Payment Notification for your site as :- http://moodle.com/enrol/paypal/ipn.php Configure in Site Wide PayPal business email Create a course using PayPal as enrolment method Try enrol as a student Pay via PayPal Sandbox account or any PayPal account
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      master
    • Rank:
      43717

      Description

      PayPal enrolments don't support using Moodle's Proxy, so we have changed over from fopen to using Moodle curl do this works correctly now.

      Thanks to Australian NSW Department of Primary Industries, Tocal College for providing funding for this fix.

        Activity

        Hide
        Petr Škoda added a comment -

        Looks ok, thanks. Submitting for integration.

        Show
        Petr Škoda added a comment - Looks ok, thanks. Submitting for integration.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Aparup Banerjee added a comment -

        Thanks, thats been integrated into master and the 22 and 23 stable branches. (not 21)

        Show
        Aparup Banerjee added a comment - Thanks, thats been integrated into master and the 22 and 23 stable branches. (not 21)
        Hide
        Ankit Agarwal added a comment -

        This needs to be tested on a public site where you can change code to use sandbox url for payment instead of regular. I donot have access to such a site now. Feel free to take this up if you can test this, else I will figure out a way to do this tomorrow.
        cheers

        Show
        Ankit Agarwal added a comment - This needs to be tested on a public site where you can change code to use sandbox url for payment instead of regular. I donot have access to such a site now. Feel free to take this up if you can test this, else I will figure out a way to do this tomorrow. cheers
        Hide
        Tim Lock added a comment -

        Hi Ankit,

        NSW DPI has tested this with a Premier PayPal account and a normal account to confirm this works. Using the sandbox account will confirm the proxying works but the transaction comes through as pending. (Doesn't save as a success transaction - maybe by design for security reasons using Sandbox accounts)

        Regards,
        Tim

        Show
        Tim Lock added a comment - Hi Ankit, NSW DPI has tested this with a Premier PayPal account and a normal account to confirm this works. Using the sandbox account will confirm the proxying works but the transaction comes through as pending. (Doesn't save as a success transaction - maybe by design for security reasons using Sandbox accounts) Regards, Tim
        Hide
        Ankit Agarwal added a comment -

        Hi Tim,
        I have tested the normal requesting behavior of paypal enrollment plugin for regressions and I couldn't find any. I dont have access to a complete setup atm to test this fully (completing the transaction). Since it has been tested as you mentioned and working properly. I am passing this issue.
        Thanks

        Show
        Ankit Agarwal added a comment - Hi Tim, I have tested the normal requesting behavior of paypal enrollment plugin for regressions and I couldn't find any. I dont have access to a complete setup atm to test this fully (completing the transaction). Since it has been tested as you mentioned and working properly. I am passing this issue. Thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Many thanks for the hard work.

        These changes have been spread upstream and are already available in the git and cvs repositories.

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work. These changes have been spread upstream and are already available in the git and cvs repositories. Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: