Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Critical
-
Resolution: Fixed
-
Affects Version/s: 2.2.4, 2.3.1
-
Fix Version/s: 2.4
-
Component/s: Backup
-
Testing Instructions:
-
Affected Branches:MOODLE_22_STABLE, MOODLE_23_STABLE
-
Fixed Branches:MOODLE_24_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-35116-master -
Pull Master Diff URL:
Description
In MDL-28657 was introduced a new naming style for backup files. It allowed the course short names to be used instead of IDs.
Unfortunately it created a regression (MDL-33812) because those new backups using short names were not being deleted during cron. MDL-33812 introduces a new naming convention which forces the ID to be in the backup name along with the short name or not.
The goal of this issue is to find a way to nicely deleting the previously created backups:
- Make sure there are no collision as 2 short names can be confused. Example: my-course and my-course-2.
- Make sure we keep backups according to the setting backup_auto_keep. This means combining both new and old backups.
Attachments
Issue Links
- has a non-specific relationship to
-
MDL-28657 Moodle Backup (Automated Backup File Names)
-
- Closed
-
-
MDL-35117 When removing excess backups we should read the backup XML file
-
- Closed
-
- has been marked as being related by
-
MDL-33812 backup_auto_keep not being honoured
-
- Closed
-
- is blocked by
-
MDL-35117 When removing excess backups we should read the backup XML file
-
- Closed
-