Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35119

Assignment upgrade tool -> 'Upgrade all assignments' button requires users to check any assignment

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.1, 2.4
    • Fix Version/s: 2.3.2
    • Component/s: Assignment
    • Labels:

      Description

      According to http://tracker.moodle.org/browse/MDL-34907?focusedCommentId=175782&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-175782

      The upgrade assignment tool has two options to select which assignments will be updated, the second one, "Upgrade all assignments" should update all the system old assignments, but the default click event behaviour is prevented if there aren't any checkbox checked.

      Discovered testing MDL-34907

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              dmonllao David Monllaó added a comment -

              Adding pull branch with proposed solution on top of integration

              Changing the onsubmit event for a onclick attached to the "Upgrade selected assignments" since there are no other form elements what could be easily used to submit the form

              Show
              dmonllao David Monllaó added a comment - Adding pull branch with proposed solution on top of integration Changing the onsubmit event for a onclick attached to the "Upgrade selected assignments" since there are no other form elements what could be easily used to submit the form
              Hide
              dmonllao David Monllaó added a comment -

              Hi Raymond,

              I've added you as a watcher (this is the new issue, we've passed the other one) do you agree with this behaviour? If you agree this change would be also integrated. Thanks for your comments and your continued work.

              Show
              dmonllao David Monllaó added a comment - Hi Raymond, I've added you as a watcher (this is the new issue, we've passed the other one) do you agree with this behaviour? If you agree this change would be also integrated. Thanks for your comments and your continued work.
              Hide
              damyon Damyon Wiese added a comment -

              The behaviour and the patch both look good to me.

              Show
              damyon Damyon Wiese added a comment - The behaviour and the patch both look good to me.
              Hide
              corleone Raymond Antonio added a comment -

              Hi David,
              just tested your patch. it is top-notch . Thanks David

              Show
              corleone Raymond Antonio added a comment - Hi David, just tested your patch. it is top-notch . Thanks David
              Hide
              nebgor Aparup Banerjee added a comment -

              pulling this in to fix this area up

              Show
              nebgor Aparup Banerjee added a comment - pulling this in to fix this area up
              Hide
              nebgor Aparup Banerjee added a comment -

              thanks David, thats integrated into master now.

              (as 386a24d7945b900da314354a538b1b3155854bec - ameneded commit's MDLxxx)

              Show
              nebgor Aparup Banerjee added a comment - thanks David, thats integrated into master now. (as 386a24d7945b900da314354a538b1b3155854bec - ameneded commit's MDLxxx)
              Hide
              nebgor Aparup Banerjee added a comment -

              Thanks David, this works for me (is upgrading all of mine atm!)

              Thanks for the quick reviews too guys!

              Show
              nebgor Aparup Banerjee added a comment - Thanks David, this works for me (is upgrading all of mine atm!) Thanks for the quick reviews too guys!
              Hide
              nebgor Aparup Banerjee added a comment -

              for MdR's sleep, this is picked into MOODLE_23_STABLE too (tested and upgrading all works fine in 23 too!) thanks all.

              Show
              nebgor Aparup Banerjee added a comment - for MdR's sleep, this is picked into MOODLE_23_STABLE too (tested and upgrading all works fine in 23 too!) thanks all.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              I'm so proud...of you, many thanks!

              http://youtu.be/n64CdfDRnZY

              Closing as fixed, ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - I'm so proud...of you, many thanks! http://youtu.be/n64CdfDRnZY Closing as fixed, ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    10/Sep/12