Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35130

Improper string/spacing in Shibboleth authentication page

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      This can be tested without an actual Shibboleth setup, but please note that after following these steps you won't be able to log back in to the instance without manually disabling Shibboleth.

      1. (If not already a Shib instance) Turn on Shibboleth authentication. Make sure the alternative login URL is set in the main Authentication page (this should happen automatically and isn't part of this patch).
      2. Purge the site caches.
      3. Logout.
      4. Attempt to log back in. You should be taken to the alternate Shibboleth authentication page.
      5. Verify that the text correctly sets up a link to the Moodle Administrator email account.

      If you need to recover the system afterwards find the alternateloginurl setting in mdl_config and null it out.

      Show
      This can be tested without an actual Shibboleth setup, but please note that after following these steps you won't be able to log back in to the instance without manually disabling Shibboleth. 1. (If not already a Shib instance) Turn on Shibboleth authentication. Make sure the alternative login URL is set in the main Authentication page (this should happen automatically and isn't part of this patch). 2. Purge the site caches. 3. Logout. 4. Attempt to log back in. You should be taken to the alternate Shibboleth authentication page. 5. Verify that the text correctly sets up a link to the Moodle Administrator email account. If you need to recover the system afterwards find the alternateloginurl setting in mdl_config and null it out.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-35130-master

      Description

      On the IDP selection page the link to notify the Moodle Administrator is improperly spaced so the white space between "contact the" and "Moodle Administrator" is linked. Additionally, the Moodle Administrator text is hard-coded.

        Attachments

          Activity

            People

            Assignee:
            cfulton Charles Fulton
            Reporter:
            cfulton Charles Fulton
            Peer reviewer:
            Michael de Raadt
            Integrator:
            Dan Poltawski
            Tester:
            Frédéric Massart
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            3 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Jan/13