Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35134

Trailing comma in course/format/weeks/format.js breaks course JS in IE

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.1, 2.4
    • Fix Version/s: 2.3.3
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide

      This needs to be tested across browsers, especially IE8.

      1. Open a course which uses the Weekly course format.
      2. Open the error console in your browser.
        • If you are using IE8, press F12 and change the Browser mode to IE8 Compatibility View and click on the Script tab.
      3. Drag and drop some resources/activites.
      4. Drag and drop some sections.
      5. VERIFY no errors appear in the error console.
      Show
      This needs to be tested across browsers, especially IE8. Open a course which uses the Weekly course format. Open the error console in your browser. If you are using IE8, press F12 and change the Browser mode to IE8 Compatibility View and click on the Script tab. Drag and drop some resources/activites. Drag and drop some sections. VERIFY no errors appear in the error console.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-35134_master

      Description

      IE doesn't like trailing commas in object (or array) definitions - and one seems to have turned up in 2.3/2.4dev, in course/format/weeks/format.js. This breaks subsequent javascript on courses using the weeks format.

        Attachments

          Activity

            People

            • Assignee:
              paul.n Paul Nicholls
              Reporter:
              paul.n Paul Nicholls
              Peer reviewer:
              Michael de Raadt
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Tim Barker
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Nov/12