Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.1, 2.4
    • Fix Version/s: 2.3.3
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      0. reset caches etc.
      1. Drag an epub file into a course.
      + File should display with epub icon (green diamond spiral thing)
      2. Edit its settings and turn on the 'show size and type' options.
      + Type should display as 'EPUB ebook'

      Show
      0. reset caches etc. 1. Drag an epub file into a course. + File should display with epub icon (green diamond spiral thing) 2. Edit its settings and turn on the 'show size and type' options. + Type should display as 'EPUB ebook'
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-35141-master

      Description

      The epub filetype is an increasingly popular open standard, and ebook content is likely to be provided on educational websites, but Moodle doesn't have a MIME type or icon for .epub files. These should be added.

      I have an icon here so will supply a patch.

        Gliffy Diagrams

          Issue Links

          1.
          Create icon for EPUB files Sub-task Closed Unassigned
           

            Activity

            Hide
            quen Sam Marshall added a comment -

            Submitting for review. Notes:

            1. The capitalisation of 'EPUB' is a bit crappy, but is the official name of the format.

            2. Other filetype icons have lots of sizes available. I did not create these, only the old-style 16px one, I think it needs to be left to the graphic designer. (I couldn't see the rationale between the different colour ribbons - I'd assumed that e.g. document types were blue, and images red or something, but they're not - it seems to make no sense at all.) Hopefully it works just with the small icon, seems like a big improvement (over nothing) on the course page at least...

            Note: Wikipedia have an SVG of the icon. I chopped text off the bottom manually. http://en.wikipedia.org/wiki/File:EPUB_logo.svg

            3. Because the MIME type contains a + (as plenty do these days), I made a slight tweak to the point where it gets the MIME type description (+ is not allowed in string id).

            4. I set it in the 'documents' group but maybe that is not appropriate and I should have left a group out or made a new 'ebooks' group? If I got it wrong please let me know.

            5. Overall, I think it's important that we should have a definition of this common type, even if it gets improved later.

            PS As noted in some other issues - after this week I'm away for three - so it might be some time before I reply to review comments, apologies in advance.

            Show
            quen Sam Marshall added a comment - Submitting for review. Notes: 1. The capitalisation of 'EPUB' is a bit crappy, but is the official name of the format. 2. Other filetype icons have lots of sizes available. I did not create these, only the old-style 16px one, I think it needs to be left to the graphic designer. (I couldn't see the rationale between the different colour ribbons - I'd assumed that e.g. document types were blue, and images red or something, but they're not - it seems to make no sense at all.) Hopefully it works just with the small icon, seems like a big improvement (over nothing) on the course page at least... Note: Wikipedia have an SVG of the icon. I chopped text off the bottom manually. http://en.wikipedia.org/wiki/File:EPUB_logo.svg 3. Because the MIME type contains a + (as plenty do these days), I made a slight tweak to the point where it gets the MIME type description (+ is not allowed in string id). 4. I set it in the 'documents' group but maybe that is not appropriate and I should have left a group out or made a new 'ebooks' group? If I got it wrong please let me know. 5. Overall, I think it's important that we should have a definition of this common type, even if it gets improved later. PS As noted in some other issues - after this week I'm away for three - so it might be some time before I reply to review comments, apologies in advance.
            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for working on that, Sam.

            I'm going to create a sub-task to create an icon.

            Show
            salvetore Michael de Raadt added a comment - Thanks for working on that, Sam. I'm going to create a sub-task to create an icon.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi Sam,

            Not to fret, the changes look perfect thank you.
            Feel free to put up for integration any time (I'll keep an eye on this and put it up if you end up on holiday before you get a chance to).

            Many thanks
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Hi Sam, Not to fret, the changes look perfect thank you. Feel free to put up for integration any time (I'll keep an eye on this and put it up if you end up on holiday before you get a chance to). Many thanks Sam
            Hide
            quen Sam Marshall added a comment -

            Submitting for integration. (I'm back from holiday now so it should be fine

            Show
            quen Sam Marshall added a comment - Submitting for integration. (I'm back from holiday now so it should be fine
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated (23 & master), thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (23 & master), thanks!
            Hide
            timb Tim Barker added a comment -

            Icon and type are displayed

            Show
            timb Tim Barker added a comment - Icon and type are displayed
            Hide
            matteo Matteo Scaramuccia added a comment -

            Hi All,
            grepping the git logs to find out an issue I'm guessing being already fixed, I found this one completely unrelated to my search, my fault ! BTW, in MDL-35622 there is a pending request for adding support for SMART Board MIME types and Marina (Glancy) said that an explicit upgrade stage must be added too, to fix those files already added into the system. Maybe it could apply here too.

            HTH,
            Matteo

            Show
            matteo Matteo Scaramuccia added a comment - Hi All, grepping the git logs to find out an issue I'm guessing being already fixed, I found this one completely unrelated to my search, my fault ! BTW, in MDL-35622 there is a pending request for adding support for SMART Board MIME types and Marina (Glancy) said that an explicit upgrade stage must be added too, to fix those files already added into the system. Maybe it could apply here too. HTH, Matteo
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            From somewhere within the clouds...

            Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - From somewhere within the clouds... Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration! Ciao
            Hide
            quen Sam Marshall added a comment -

            Matteo: Oops. You/Marina are probably right, I didn't think of the mime type being stored in existing files table. Don't know how important it is though.

            If people want, I can code it (under another issue number of course).

            Show
            quen Sam Marshall added a comment - Matteo: Oops. You/Marina are probably right, I didn't think of the mime type being stored in existing files table. Don't know how important it is though. If people want, I can code it (under another issue number of course).
            Hide
            celia Celia added a comment -

            Hi All,
            I want to add epub file types in moodle. So I think I should create activity module,which name is called 'epub'.
            When I create this module,I can open the epub file and read in the epub module.
            Now,I haven't any idea in php code.Please tell me,how do I do??

            Thanks you very much,thank.

            Show
            celia Celia added a comment - Hi All, I want to add epub file types in moodle. So I think I should create activity module,which name is called 'epub'. When I create this module,I can open the epub file and read in the epub module. Now,I haven't any idea in php code.Please tell me,how do I do?? Thanks you very much,thank.
            Hide
            quen Sam Marshall added a comment -

            Celia: I don't understand the question. Epub file types are supported in Moodle (so it will show a suitable icon and description) using the standard 'File' module in Moodle 2.3.3 and above, which is what this issue was about. There isn't any need to create a new activity module.

            Show
            quen Sam Marshall added a comment - Celia: I don't understand the question. Epub file types are supported in Moodle (so it will show a suitable icon and description) using the standard 'File' module in Moodle 2.3.3 and above, which is what this issue was about. There isn't any need to create a new activity module.
            Hide
            marycooch Mary Cooch added a comment -

            Celia - I think perhaps you are wanting Moodle to open Epub files for you but, as with other files like Powerpoint or Word, you need to have the software on your computer to be able to view them ,rather than having Moodle open them.

            Show
            marycooch Mary Cooch added a comment - Celia - I think perhaps you are wanting Moodle to open Epub files for you but, as with other files like Powerpoint or Word, you need to have the software on your computer to be able to view them ,rather than having Moodle open them.
            Hide
            celia Celia added a comment - - edited

            Sam Marshall and Mary Cooch:

            Thank you for your response. My purpose is wish upload "epub" file and "view" them in Moodle course.
            Let anyone (teacher or student)can upload or view them.
            I search https://moodle.org/plugins, but no plugins can open and view them.
            Thus I want to create a new activity module that like SCORM module.
            It's can upload and view content of epub type in Moodle course.

            Thanks all!!!!!

            Show
            celia Celia added a comment - - edited Sam Marshall and Mary Cooch: Thank you for your response. My purpose is wish upload "epub" file and "view" them in Moodle course. Let anyone (teacher or student)can upload or view them. I search https://moodle.org/plugins , but no plugins can open and view them. Thus I want to create a new activity module that like SCORM module. It's can upload and view content of epub type in Moodle course. Thanks all!!!!!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/12