Moodle
  1. Moodle
  2. MDL-35151

Anomaly theme - no spacing between paragraphs in forum posts

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.4, 2.3.1, 2.4
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Forum, Themes
    • Labels:
    • Rank:
      43783

      Description

      When a user creates a forum post with multiple paragraphs, the paragraph tags are correctly applied, the spacing between the paragraphs is visible in edit mode, but the post displays with no spacing.

      Here's the relevant bit from anomaly/style/general.css, setting the top/bottom margins to 0:

      .forumpost .content .shortenedpost a,
      .forumpost .content p {
          margin: 0 10px;
          padding: 0;
      }
      

      It makes sense for the shortened post link margins to remain 0, but the paragraph margins ought to be something reasonable.

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for reporting this.

          I've put that on the backlog.

          In the meantime feel free to help us work on this issue. If you are able to provide a patch or links to your Git repository branch, please add a patch label so we will spot it.

          Show
          Michael de Raadt added a comment - Thanks for reporting this. I've put that on the backlog. In the meantime feel free to help us work on this issue. If you are able to provide a patch or links to your Git repository branch, please add a patch label so we will spot it.
          Hide
          Mary Evans added a comment -

          I'll get this fixed this weekend ready for Monday.
          It's a simple fix just need to remove

          .forumpost .content p 

          and let YUI CSS take over.

          Show
          Mary Evans added a comment - I'll get this fixed this weekend ready for Monday. It's a simple fix just need to remove .forumpost .content p and let YUI CSS take over.
          Hide
          Mary Evans added a comment -

          All being well this should be in next weeks updates of Moodle stable versions.

          Show
          Mary Evans added a comment - All being well this should be in next weeks updates of Moodle stable versions.
          Hide
          Aparup Banerjee added a comment -

          cool, thats integrated into 22, 23 and master for testing.

          Show
          Aparup Banerjee added a comment - cool, thats integrated into 22, 23 and master for testing.
          Hide
          Mary Evans added a comment -

          Excellent! thanks

          Show
          Mary Evans added a comment - Excellent! thanks
          Hide
          David Monllaó added a comment -

          It passes, tested in 22 and master, YUI p styles are applied

          Show
          David Monllaó added a comment - It passes, tested in 22 and master, YUI p styles are applied
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for the hard work.

          These changes have been spread upstream and are already available in the git and cvs repositories.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work. These changes have been spread upstream and are already available in the git and cvs repositories. Ciao

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: