Moodle
  1. Moodle
  2. MDL-35156

Guide description is not shown to students

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.3.3
    • Component/s: Grading methods
    • Labels:
    • Testing Instructions:
      Hide
      1. Create an assignment/assign with marking guide grading
      2. Add a marking guide, make sure it contains description.
      3. Make sure student can see description in grading method preview (following link from navigation bar and in submission results)
      4. As manager make sure you can always see description - when you click 'Advanced grading', when you save the guide as template, when you pick guide from template.
      Show
      Create an assignment/assign with marking guide grading Add a marking guide, make sure it contains description. Make sure student can see description in grading method preview (following link from navigation bar and in submission results) As manager make sure you can always see description - when you click 'Advanced grading', when you save the guide as template, when you pick guide from template.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Rank:
      43788

      Description

      Discovered while working on MDL-34310

      Please fix for 2.3 references to non-existing options that result in non-showing the description
      https://github.com/moodle/moodle/blob/master/grade/grading/form/guide/preview.php#L52
      https://github.com/moodle/moodle/blob/master/grade/grading/form/guide/lib.php#L875

      Fixed for master already in MDL-34310

        Issue Links

          Activity

          Hide
          Dan Marsden added a comment -

          oops - thanks for the pointer Marina, will get this sorted today.

          Show
          Dan Marsden added a comment - oops - thanks for the pointer Marina, will get this sorted today.
          Hide
          Dan Marsden added a comment -

          I think testing instructions are right - Marina would you mind checking? - thanks!

          Show
          Dan Marsden added a comment - I think testing instructions are right - Marina would you mind checking? - thanks!
          Hide
          Marina Glancy added a comment -

          looks fine for me, thanks Dan

          Show
          Marina Glancy added a comment - looks fine for me, thanks Dan
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (23 only), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (23 only), thanks!
          Hide
          Frédéric Massart added a comment -

          Test passed on 2.3. Thanks!

          Show
          Frédéric Massart added a comment - Test passed on 2.3. Thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio

          This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

          Thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: