Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35171

Date Picker displays incorrect Month for Months with less than 31 days

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.2.5, 2.3.1, 2.4
    • Fix Version/s: 2.2.6, 2.3.3
    • Component/s: Forms Library
    • Labels:
    • Testing Instructions:
      Hide

      Test pre-requisites

      • A few languages packs installed, including with non-enlish characters
      • Installing corresponding locales on your system `sudo locale-gen --no-archive ja_JP.UTF-8`
      • Set your machine date to the 31th of any month

      Test 1

      1. Go to your home page and switch to English language pack
      2. Go to the calendar, and add a new event
      3. Make sure that the pop-up date selector correctly displays each month
        • Correct month (February is not March, check that you'll never have two similar names while going from one month to another)

      Test 2

      1. Go to your home page and switch to a funky language pack
      2. Go to the calendar, and add a new event
      3. Make sure that the pop-up date selector correctly displays each month
        • Month and days are correctly translated
        • Correct month (February is not March, check that you'll never have two similar names while going from one month to another)

      Test 3

      1. Go to your home page and switch back to English
      2. Change your machine timezone to UTC-0800 or at least really different than the one previously used
      3. Go to the calendar, and add a new event
      4. Make sure that the pop-up date selector correctly displays each month
        • Month and days are correctly translated
        • Correct month (February is not March, check that you'll never have two similar names while going from one month to another)

      Test 4

      1. Go to your home page and switch back to English
      2. Change your user timezone to UTC-0800 or at least really different than the one previously used
      3. Go to the calendar, and add a new event
      4. Make sure that the pop-up date selector correctly displays each month
        • Month and days are correctly translated
        • Correct month (February is not March, check that you'll never have two similar names while going from one month to another)

      Test 5

      1. Reward yourself with a candy!
      Show
      Test pre-requisites A few languages packs installed, including with non-enlish characters Installing corresponding locales on your system `sudo locale-gen --no-archive ja_JP.UTF-8` Set your machine date to the 31th of any month Test 1 Go to your home page and switch to English language pack Go to the calendar, and add a new event Make sure that the pop-up date selector correctly displays each month Correct month (February is not March, check that you'll never have two similar names while going from one month to another) Test 2 Go to your home page and switch to a funky language pack Go to the calendar, and add a new event Make sure that the pop-up date selector correctly displays each month Month and days are correctly translated Correct month (February is not March, check that you'll never have two similar names while going from one month to another) Test 3 Go to your home page and switch back to English Change your machine timezone to UTC-0800 or at least really different than the one previously used Go to the calendar, and add a new event Make sure that the pop-up date selector correctly displays each month Month and days are correctly translated Correct month (February is not March, check that you'll never have two similar names while going from one month to another) Test 4 Go to your home page and switch back to English Change your user timezone to UTC-0800 or at least really different than the one previously used Go to the calendar, and add a new event Make sure that the pop-up date selector correctly displays each month Month and days are correctly translated Correct month (February is not March, check that you'll never have two similar names while going from one month to another) Test 5 Reward yourself with a candy!
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:

      Description

      After applying the patch from:
      http://tracker.moodle.org/browse/MDL-34708
      https://github.com/nebgor/moodle/commit/201816346877bde81b2673908efd2bb598fdccf5
      our date picker was working correctly until today.

      The date picker now does the following:
      August 2012 has the name of August 2012
      September 2012 has the name of October 2012
      October 2012 has the name of October 2012
      Nov 12 -> Dec 12
      Dec 12 -> Dec 12
      Jan 13 -> Jan 13
      Feb 12 -> Mar 13
      Mar 13 -> Mar 13
      Apr 13 -> May 13
      May 13 -> May 13
      Jun 13 -> Jul 13
      Jul 13 -> Jul 13
      Aug 13 -> Aug 13

      I tested this on latest code from the git repo, Moodle 2.3.1+ (Build: 20120831), and it has the issue as well. When test it was Aug 31, ~12:30pm MDT. I made sure the timezone data was up to date and tried different server default timezone settings. I wonder if it is a boundary condition problem because of the end of the month with 31 days. It looks like if a month has 31 days it displays the correct name and if it has less it displays the next month.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  10 Vote for this issue
                  Watchers:
                  10 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/Nov/12