Moodle
  1. Moodle
  2. MDL-35180

Afterburner theme issue - group 'add/remove users' with IE9

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.4, 2.3.1, 2.4
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Note: This TEST requires IE9 browser set to compatibility mode.
      (Clicking F12 (function key) in IE9 brings up a Web Developer view where you can set IE9 Compatibility)

      1. Select Afterburner from theme selector
      2. Select Group from Settings > User > Groups
      3. Either create a new group or select one if available
      4. TEST using IE9 (Compatibility Mode)that when searching for users that the selection area is light grey with dark text and not white with white text. It may go white but should still show dark blue text.
      Show
      Note: This TEST requires IE9 browser set to compatibility mode. (Clicking F12 (function key) in IE9 brings up a Web Developer view where you can set IE9 Compatibility) Select Afterburner from theme selector Select Group from Settings > User > Groups Either create a new group or select one if available TEST using IE9 (Compatibility Mode)that when searching for users that the selection area is light grey with dark text and not white with white text. It may go white but should still show dark blue text.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-35180_master
    • Rank:
      43816

      Description

      (Per http://moodle.org/mod/forum/discuss.php?d=210213)

      With IE9 in a course on the group 'add/remove users' screen. When first loaded, the selection boxes look as expected, white text on blue background.

      After typing into either 'search' box (group members or potential members) the blue background becomes transparent, effectively white text on white background.

      This does not affect Firefox browser in my testing. Seems the same behavior on both my Moodle 2.2 and 2.3.1 sites.

        Activity

        Hide
        Michael Lewis added a comment -

        Group selection screen in IE9 before search

        Show
        Michael Lewis added a comment - Group selection screen in IE9 before search
        Hide
        Michael Lewis added a comment -

        Group selection screen in IE9 after search

        Show
        Michael Lewis added a comment - Group selection screen in IE9 after search
        Hide
        Mary Evans added a comment -

        Thank you Michael for reporting this, I'll try and get the fix done today.

        Show
        Mary Evans added a comment - Thank you Michael for reporting this, I'll try and get the fix done today.
        Hide
        Mary Evans added a comment - - edited

        Michael:

        I have just been testing this and find nothing wrong in IE9. However if I change to IE9 (Compatibility Mode) which uses IE7 Document Standards then the theme does display this strange behaviour.

        To make sure your browser does not automatically set Compatibility Mode when viewing Moodle in IE9, you need to change the settings in Tools -> Compatibility View Settings from your browser menu bar, and make sure your Moodle site URL is not listed in the pop-up window. (see uploaded images)

        To see the different compatibility mode settings which Web Developers use when testing. just click F12 (Function Key 12) on your keyboard and your browser window will split in two with the Web Developer window in the lower part of your screen. You will see the various options available to you in the menu bar which runs across the top of this lower window. It should say:

        | Browser Mode: IE9 | Document Mode: IE9 standards |

        for IE9 to work correctly. Clicking on either of those two links produces a drop-down menu from which to choose the various combinations of browser version and document standards for that particular browser.

        I'll see if I can fix the problem adding some CSS to change the colour of the text from white to dark blue in this situation with an IE7 specific CSS rule.

        Show
        Mary Evans added a comment - - edited Michael: I have just been testing this and find nothing wrong in IE9. However if I change to IE9 (Compatibility Mode) which uses IE7 Document Standards then the theme does display this strange behaviour. To make sure your browser does not automatically set Compatibility Mode when viewing Moodle in IE9, you need to change the settings in Tools -> Compatibility View Settings from your browser menu bar, and make sure your Moodle site URL is not listed in the pop-up window. (see uploaded images) To see the different compatibility mode settings which Web Developers use when testing. just click F12 (Function Key 12) on your keyboard and your browser window will split in two with the Web Developer window in the lower part of your screen. You will see the various options available to you in the menu bar which runs across the top of this lower window. It should say: | Browser Mode: IE9 | Document Mode: IE9 standards | for IE9 to work correctly. Clicking on either of those two links produces a drop-down menu from which to choose the various combinations of browser version and document standards for that particular browser. I'll see if I can fix the problem adding some CSS to change the colour of the text from white to dark blue in this situation with an IE7 specific CSS rule.
        Hide
        Michael Lewis added a comment -

        Mary, thanks for the explanation. I think my organisation has the compatibility view rule turned on by default due to some older web apps still in use.

        I'll update my guidance for the Moodle sites but if you are able to provide a workaround rule for IE7/compatibility view mode - that, like you, would be awesome

        M.

        Show
        Michael Lewis added a comment - Mary, thanks for the explanation. I think my organisation has the compatibility view rule turned on by default due to some older web apps still in use. I'll update my guidance for the Moodle sites but if you are able to provide a workaround rule for IE7/compatibility view mode - that, like you, would be awesome M.
        Hide
        Aparup Banerjee added a comment -

        Thanks Mary
        that's been integrated into 22, 23 and master for testing.

        Show
        Aparup Banerjee added a comment - Thanks Mary that's been integrated into 22, 23 and master for testing.
        Hide
        Michael de Raadt added a comment -

        Test result: Success!

        Tested in 2.2, 2.3 and master in IE9 (with and without compatibility mode), FF and Chrome.

        Show
        Michael de Raadt added a comment - Test result: Success! Tested in 2.2, 2.3 and master in IE9 (with and without compatibility mode), FF and Chrome.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Many thanks for the hard work.

        These changes have been spread upstream and are already available in the git and cvs repositories.

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work. These changes have been spread upstream and are already available in the git and cvs repositories. Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: