Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Libraries
    • Labels:

      Description

      import adodb 5.17

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Petr, lib/adodb/readme_moodle.txt says that we had still some customization:

              • fixed leading whitespace in adodb-active-record.inc.php

              Can you confirm if that fix is already upstream or if we continue needing that comment there? I've looked for any customization but haven't been able to find anything.

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Petr, lib/adodb/readme_moodle.txt says that we had still some customization: fixed leading whitespace in adodb-active-record.inc.php Can you confirm if that fix is already upstream or if we continue needing that comment there? I've looked for any customization but haven't been able to find anything.
              Hide
              skodak Petr Skoda added a comment -

              ooops, verifying

              Show
              skodak Petr Skoda added a comment - ooops, verifying
              Hide
              skodak Petr Skoda added a comment -

              That file seems ok now, I have removed the change description. I have also verified the commit diff to make 100% sure no invalid whitespace was introduced in this commit.

              Show
              skodak Petr Skoda added a comment - That file seems ok now, I have removed the change description. I have also verified the commit diff to make 100% sure no invalid whitespace was introduced in this commit.
              Hide
              skodak Petr Skoda added a comment -

              Arrrgh, I just noticed I messed up MDL in the original commit, squashed commit pushed to my repo, sorrrry

              Show
              skodak Petr Skoda added a comment - Arrrgh, I just noticed I messed up MDL in the original commit, squashed commit pushed to my repo, sorrrry
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Integrated (2.4 only), thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (2.4 only), thanks!
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Works Fine,

              Thanks for improving this, Petr.

              Show
              rajeshtaneja Rajesh Taneja added a comment - Works Fine, Thanks for improving this, Petr.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Many thanks for the hard work.

              These changes have been spread upstream and are already available in the git and cvs repositories.

              Ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work. These changes have been spread upstream and are already available in the git and cvs repositories. Ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    3/Dec/12