Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Libraries
    • Labels:
    • Rank:
      43821

      Description

      import adodb 5.17

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          Petr, lib/adodb/readme_moodle.txt says that we had still some customization:

          • fixed leading whitespace in adodb-active-record.inc.php

          Can you confirm if that fix is already upstream or if we continue needing that comment there? I've looked for any customization but haven't been able to find anything.

          Show
          Eloy Lafuente (stronk7) added a comment - Petr, lib/adodb/readme_moodle.txt says that we had still some customization: fixed leading whitespace in adodb-active-record.inc.php Can you confirm if that fix is already upstream or if we continue needing that comment there? I've looked for any customization but haven't been able to find anything.
          Hide
          Petr Škoda added a comment -

          ooops, verifying

          Show
          Petr Škoda added a comment - ooops, verifying
          Hide
          Petr Škoda added a comment -

          That file seems ok now, I have removed the change description. I have also verified the commit diff to make 100% sure no invalid whitespace was introduced in this commit.

          Show
          Petr Škoda added a comment - That file seems ok now, I have removed the change description. I have also verified the commit diff to make 100% sure no invalid whitespace was introduced in this commit.
          Hide
          Petr Škoda added a comment -

          Arrrgh, I just noticed I messed up MDL in the original commit, squashed commit pushed to my repo, sorrrry

          Show
          Petr Škoda added a comment - Arrrgh, I just noticed I messed up MDL in the original commit, squashed commit pushed to my repo, sorrrry
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (2.4 only), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (2.4 only), thanks!
          Hide
          Rajesh Taneja added a comment -

          Works Fine,

          Thanks for improving this, Petr.

          Show
          Rajesh Taneja added a comment - Works Fine, Thanks for improving this, Petr.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for the hard work.

          These changes have been spread upstream and are already available in the git and cvs repositories.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work. These changes have been spread upstream and are already available in the git and cvs repositories. Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: