Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35581 META: tasks related to RTL theme fixes before 2.4 freeze (Week 39)
  3. MDL-35202

Unable to set a new grade or update old grade when using the new Assignment type (Assign) while in Hebrew UI

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Change the language to hebrew (he)
      2. Go to the grading table
      3. Click the grade button for a submission
      4. Change the grade
      5. Click save on the grading form (top right in the group of buttons)
        Expected result: The grading table should show the updated grade
        Actual result: The grading table shows the old grade
      Show
      Change the language to hebrew (he) Go to the grading table Click the grade button for a submission Change the grade Click save on the grading form (top right in the group of buttons) Expected result: The grading table should show the updated grade Actual result: The grading table shows the old grade
    • Workaround:
      Hide

      See code change in the description.

      Show
      See code change in the description.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      When UI is set to Hebrew (and probably other non English languages) It is not possible to update a grade or set a new grade in the new "Assign" (assignment type) submission form (mod/assign/view.php?id=XX&action=grading).

      Changing the following fixes this issue:
      moodle2/mod/assign/locallib.php (line 330)

                  } else if (optional_param('savegrade', null, PARAM_ALPHA)) {

      change to:

                  } else if (optional_param('savegrade', null, PARAM_RAW)) {

        Attachments

          Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-41468 Unable to remove a calendar from "Manage Calendar subscriptions" page, When in RTL mode

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-35529 System wide, unable to submit an "Intro" Form field If it has only non-English content.

          • Major - Major loss of function, incorrect output
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-35428 New assign module - grading and feedback are not working for Korean language.

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              nadavkav Nadav Kavalerchik
              Integrator:
              Dan Poltawski
              Tester:
              Mark Nelson
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              3 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Nov/12