Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35581 META: tasks related to RTL theme fixes before 2.4 freeze (Week 39)
  3. MDL-35202

Unable to set a new grade or update old grade when using the new Assignment type (Assign) while in Hebrew UI

    XMLWordPrintable

Details

    • MOODLE_22_STABLE, MOODLE_23_STABLE
    • MOODLE_23_STABLE
    • Hide

      See code change in the description.

      Show
      See code change in the description.
    • Hide
      1. Change the language to hebrew (he)
      2. Go to the grading table
      3. Click the grade button for a submission
      4. Change the grade
      5. Click save on the grading form (top right in the group of buttons)
        Expected result: The grading table should show the updated grade
        Actual result: The grading table shows the old grade
      Show
      Change the language to hebrew (he) Go to the grading table Click the grade button for a submission Change the grade Click save on the grading form (top right in the group of buttons) Expected result: The grading table should show the updated grade Actual result: The grading table shows the old grade

    Description

      When UI is set to Hebrew (and probably other non English languages) It is not possible to update a grade or set a new grade in the new "Assign" (assignment type) submission form (mod/assign/view.php?id=XX&action=grading).

      Changing the following fixes this issue:
      moodle2/mod/assign/locallib.php (line 330)

                  } else if (optional_param('savegrade', null, PARAM_ALPHA)) {

      change to:

                  } else if (optional_param('savegrade', null, PARAM_RAW)) {

      Attachments

        Issue Links

          Activity

            People

              damyon Damyon Wiese
              nadavkav Nadav Kavalerchik
              Dan Poltawski Dan Poltawski
              Mark Nelson Mark Nelson
              Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              3 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/Nov/12