HTML links not enumerated correctly in forum post copies sent to email

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.3, 2.4.3
Fix Version/s: 2.4.5, 2.5.1
Component/s: Forum
Labels:
- triaged

Testing Instructions:
Hide

Testing difficulty: trivial

Log in (as a student, teacher or admin - does not matter) and modify your settings in the profile so that you want to receive e-mails in the plain text format. Make sure the messaging setting is set so the user receives subscribed forums posts via email.

Subscribe to a forum.

Submit a post into that forum. Make sure the post contains couple of HTML links.

Wait for the post coming to your inbox (you may want to use the "send emails immediately" feature).

TEST: Check that links are all listed at the bottom of the email, enumerated as [1], [2], [3] etc. and that they refer to a correct [1], [2], [3] etc. in the post text.
Show
Testing difficulty: trivial Log in (as a student, teacher or admin - does not matter) and modify your settings in the profile so that you want to receive e-mails in the plain text format. Make sure the messaging setting is set so the user receives subscribed forums posts via email. Subscribe to a forum. Submit a post into that forum. Make sure the post contains couple of HTML links. Wait for the post coming to your inbox (you may want to use the "send emails immediately" feature). TEST: Check that links are all listed at the bottom of the email, enumerated as [1] , [2] , [3] etc. and that they refer to a correct [1] , [2] , [3] etc. in the post text.
Affected Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE
Fixed Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE
Pull from Repository:
git://github.com/mudrd8mz/moodle.git
Pull 2.4 Branch:
~~MDL-35206~~-email-links_24
Pull 2.4 Diff URL:
https://github.com/mudrd8mz/moodle/compare/c982630a942496de5009f5d784ee9f8a0edea3ae...bdd014e2c2661f650dadfc837e81830a05d55e34
Pull 2.5 Branch:
~~MDL-35206~~-email-links_25
Pull 2.5 Diff URL:
https://github.com/mudrd8mz/moodle/compare/32e550a6eb1f4ca0a009400eeb219ea0683f6cc9...52d485c435cdaa621ef54324a516a74336478c55
Pull Master Branch:
~~MDL-35206~~-email-links
Pull Master Diff URL:
https://github.com/mudrd8mz/moodle/compare/f0d37f4ac5f6137893c8208f4d10028d2b96079d...a7182af94aff570f7a45075d0b90431b9f2acde9

Description

I spotted this in the posts from "Integration, exposed" forum at moodle.org. In my preferences, I have selected "Plain text" as the format for the post from forums I am subscribed to. In this set-up, HTML links in the post body are converted into a numerical reference such as [1] or [2] and then there is a list of all links at the bottom of the text. The problem is that the in-text enumeration starts with [2] and not [1]. Due to this buggy offset, the links in the list of links do not match the referenced places.

Issue Links

is duplicated by

MDL-37941 Automatic numbering of links in forum subscription mails starts with 2 instead of 1

MDL-38844 Hyperlinks in forum emails (text) starts counting from 2 instead 1

MDL-41705 Text-format mail from forum link numbering

testing discovered

MDL-41672 Identical HTML links not enumerated correctly in forum post copies sent to email

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

David Mudrak added a comment - 03/Sep/12 7:04 PM

Adding a copy of the email to illustrate the problem.

Using Moodle -> Forums -> Integration, exposed -> Integration round 2012-08-31
Summary - oh my, where is moodle.org?
---------------------------------------------------------------------
Integration round 2012-08-31 Summary - oh my, where is moodle.org?
by Eloy Lafuente (stronk7) - Friday, 31 August 2012, 10:09 PM
---------------------------------------------------------------------
COLD NUMBERS: 

52 ISSUES [2] have been successfully integrated with 18 rejected
and 6 delayed. That is 74% SUCCESS, we need to improve! 

NOTES: 

Next week integration cycle will be the last one before PACKAGING AND
RELEASING MOODLE 1.9.20 and 2.1.8 (ONLY SECURITY FIXES), and also 2.2.5 and
2.3.2 (FULLY SUPPORTED). 

Some interesting stuff is happening behind the scenes, that will debut with
MOODLE 2.4 [3] LATER THIS YEAR. Time runs so, the sooner things land, the
better. CODE FREEZE is planned for early November. AND THE RELEASE, on
month later. 

It's important to take a look to the DEVELOPMENT DOCUMENTATION THAT YOU
NEED TO COMPLETE [4], to allow everybody to know how to play with your
awesome code and APIs. Please, do it with the CARE you would expect from
other Developers. 

Today, for some hours, MOODLE.ORG [5] HAS BEEN KAPUT, down, unreachable,
dead. 8-o 

The cause for such a disaster, discovered after a RIGOROUS INVESTIGATION by
the Moodle MiB [6], has been an elephant that accessed (flying, through
the window!) to MOODLE HQ and, with the help of 2 dangerous
peanuts, threatened everybody, causing the CAOS and the MASS HYSTERIA,
until our beloved SYSTEM ADMIN, MATT SHARPE, was able to TAME IT from
Sidney, only armed with his remote console. KUDOS FOR MATT!  

HOT TOPICS: 

 	* MDL-25492 - Fixes and improvements to the BB6 question importer.
 	* MDL-34290 - Important fixes both to file references handling and the
Dropbox repository.
 	* MDL-29598 - Problems on restore with the handling of grade letters.
 	* MDL-34696 - Improvements to the enrolments subsystem.
 	* MDL-34192 - Problems grading in the assignment under Oracle.
 	* And lots more in areas like questions, html editor, courses,
assignments, libraries, navigation...

WARM THANKS: 

 	* To JEAN-MICHEL VEDRINE for his great collaboration fixing and
improving various problems with question formats. (y)

	* To DAMYON WIESE and RAYMOND ANTONIO (from Moodle Partner NetSpot) for
their continue work fixing and polishing the new assignment module. (y)
 	* To everybody that has been involved with the GSOC 2012 [7], mentors,
students, ... big thanks! (y)

Ciao all, stronk7 :-)

Links:
------
[1]
http://tracker.moodle.org/secure/IssueNavigator.jspa?reset=true&amp;jqlQuery=project+%3D+MDL+AND+%22Integration+date%22+%3D+2012-08-31
[2] http://docs.moodle.org/dev/Roadmap
[3]
http://tracker.moodle.org/secure/IssueNavigator.jspa?reset=true&amp;jqlQuery=labels+%3D+dev_docs_required+AND+assignee+%3D+currentUser%28%29
[4] http://moodle.org
[5] http://moodle.com/hq/team/
[6] http://docs.moodle.org/dev/GSOC#2012


---------------------------------------------------------------------
This is a copy of a message posted on the Using Moodle website.

To reply click on this link:
http://moodle.org/mod/forum/post.php?reply=916897

---------------------------------------------------------------------
Unsubscribe from this forum: http://moodle.org/mod/forum/subscribe.php?id=1153

Show

David Mudrak added a comment - 03/Sep/12 7:04 PM Adding a copy of the email to illustrate the problem. Using Moodle -> Forums -> Integration, exposed -> Integration round 2012-08-31 Summary - oh my, where is moodle.org? --------------------------------------------------------------------- Integration round 2012-08-31 Summary - oh my, where is moodle.org? by Eloy Lafuente (stronk7) - Friday, 31 August 2012, 10:09 PM --------------------------------------------------------------------- COLD NUMBERS: 52 ISSUES [2] have been successfully integrated with 18 rejected and 6 delayed. That is 74% SUCCESS, we need to improve! NOTES: Next week integration cycle will be the last one before PACKAGING AND RELEASING MOODLE 1.9.20 and 2.1.8 (ONLY SECURITY FIXES), and also 2.2.5 and 2.3.2 (FULLY SUPPORTED). Some interesting stuff is happening behind the scenes, that will debut with MOODLE 2.4 [3] LATER THIS YEAR. Time runs so, the sooner things land, the better. CODE FREEZE is planned for early November. AND THE RELEASE, on month later. It's important to take a look to the DEVELOPMENT DOCUMENTATION THAT YOU NEED TO COMPLETE [4], to allow everybody to know how to play with your awesome code and APIs. Please, do it with the CARE you would expect from other Developers. Today, for some hours, MOODLE.ORG [5] HAS BEEN KAPUT, down, unreachable, dead. 8-o The cause for such a disaster, discovered after a RIGOROUS INVESTIGATION by the Moodle MiB [6], has been an elephant that accessed (flying, through the window!) to MOODLE HQ and, with the help of 2 dangerous peanuts, threatened everybody, causing the CAOS and the MASS HYSTERIA, until our beloved SYSTEM ADMIN, MATT SHARPE, was able to TAME IT from Sidney, only armed with his remote console. KUDOS FOR MATT! HOT TOPICS: * MDL-25492 - Fixes and improvements to the BB6 question importer. * MDL-34290 - Important fixes both to file references handling and the Dropbox repository. * MDL-29598 - Problems on restore with the handling of grade letters. * MDL-34696 - Improvements to the enrolments subsystem. * MDL-34192 - Problems grading in the assignment under Oracle. * And lots more in areas like questions, html editor, courses, assignments, libraries, navigation... WARM THANKS: * To JEAN-MICHEL VEDRINE for his great collaboration fixing and improving various problems with question formats. (y) * To DAMYON WIESE and RAYMOND ANTONIO (from Moodle Partner NetSpot) for their continue work fixing and polishing the new assignment module. (y) * To everybody that has been involved with the GSOC 2012 [7], mentors, students, ... big thanks! (y) Ciao all, stronk7 :-) Links: ------ [1] http: //tracker.moodle.org/secure/IssueNavigator.jspa?reset= true &jqlQuery=project+%3D+MDL+AND+%22Integration+date%22+%3D+2012-08-31 [2] http: //docs.moodle.org/dev/Roadmap [3] http: //tracker.moodle.org/secure/IssueNavigator.jspa?reset= true &jqlQuery=labels+%3D+dev_docs_required+AND+assignee+%3D+currentUser%28%29 [4] http: //moodle.org [5] http: //moodle.com/hq/team/ [6] http: //docs.moodle.org/dev/GSOC#2012 --------------------------------------------------------------------- This is a copy of a message posted on the Using Moodle website. To reply click on this link: http: //moodle.org/mod/forum/post.php?reply=916897 --------------------------------------------------------------------- Unsubscribe from this forum: http: //moodle.org/mod/forum/subscribe.php?id=1153

Hide

Permalink

Michael de Raadt added a comment - 03/Apr/13 1:38 AM - edited

This issue has now been duplicated at least twice.

Who are all these people who continue to use text-only email?

Show

Michael de Raadt added a comment - 03/Apr/13 1:38 AM - edited This issue has now been duplicated at least twice. Who are all these people who continue to use text-only email?

Hide

Permalink

Alexander Bias added a comment - 03/Apr/13 5:40 AM

These people like a well-styled, mono-spaced, continuous, plain-text reading experience without any visual clutter and embedded images

Show

Alexander Bias added a comment - 03/Apr/13 5:40 AM These people like a well-styled, mono-spaced, continuous, plain-text reading experience without any visual clutter and embedded images

Hide

Permalink

Mark Nelson added a comment - 15/May/13 8:14 AM

This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

Show

Mark Nelson added a comment - 15/May/13 8:14 AM This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

Hide

Permalink

David Mudrak added a comment - 28/Jun/13 11:23 AM

Submitting for integration into 2.6, 2.5 and 2.4.

Show

David Mudrak added a comment - 28/Jun/13 11:23 AM Submitting for integration into 2.6, 2.5 and 2.4.

Hide

Permalink

Sam Hemelryk added a comment - 01/Jul/13 1:12 AM

Thanks David, this has been integrated now.

Show

Sam Hemelryk added a comment - 01/Jul/13 1:12 AM Thanks David, this has been integrated now.

Hide

Permalink

Andrew Davis added a comment - 03/Jul/13 3:59 AM

Works as described. Passing.

Show

Andrew Davis added a comment - 03/Jul/13 3:59 AM Works as described. Passing.

Hide

Permalink

Damyon Wiese added a comment - 04/Jul/13 9:00 AM

This issue is fixed! Hurray! Hurray!
Your issue is fixed, what a wonderful day!

Cheers, Damyon

Show

Damyon Wiese added a comment - 04/Jul/13 9:00 AM This issue is fixed! Hurray! Hurray! Your issue is fixed, what a wonderful day! Cheers, Damyon

People

Assignee:

David Mudrak

Reporter:

David Mudrak

Integrator:

Sam Hemelryk

Tester:

Andrew Davis

Participants:

Alexander Bias, Andrew Davis, Damyon Wiese, David Mudrak, Mark Nelson, Michael de Raadt, Sam Hemelryk

Vote (1)

Watch (7)

Dates

Created:

03/Sep/12 7:02 PM

Updated:

22/Sep/13 8:23 AM

Resolved:

04/Jul/13 9:00 AM

Agile

View on Board