Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35206

HTML links not enumerated correctly in forum post copies sent to email

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3, 2.4.3
    • Fix Version/s: 2.4.5, 2.5.1
    • Component/s: Forum
    • Labels:
    • Testing Instructions:
      Hide

      Testing difficulty: trivial

      • Log in (as a student, teacher or admin - does not matter) and modify your settings in the profile so that you want to receive e-mails in the plain text format. Make sure the messaging setting is set so the user receives subscribed forums posts via email.
      • Subscribe to a forum.
      • Submit a post into that forum. Make sure the post contains couple of HTML links.
      • Wait for the post coming to your inbox (you may want to use the "send emails immediately" feature).
      • TEST: Check that links are all listed at the bottom of the email, enumerated as [1], [2], [3] etc. and that they refer to a correct [1], [2], [3] etc. in the post text.
      Show
      Testing difficulty: trivial Log in (as a student, teacher or admin - does not matter) and modify your settings in the profile so that you want to receive e-mails in the plain text format. Make sure the messaging setting is set so the user receives subscribed forums posts via email. Subscribe to a forum. Submit a post into that forum. Make sure the post contains couple of HTML links. Wait for the post coming to your inbox (you may want to use the "send emails immediately" feature). TEST: Check that links are all listed at the bottom of the email, enumerated as [1] , [2] , [3] etc. and that they refer to a correct [1] , [2] , [3] etc. in the post text.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-35206-email-links
    • Pull Master Diff URL:

      Description

      I spotted this in the posts from "Integration, exposed" forum at moodle.org. In my preferences, I have selected "Plain text" as the format for the post from forums I am subscribed to. In this set-up, HTML links in the post body are converted into a numerical reference such as [1] or [2] and then there is a list of all links at the bottom of the text. The problem is that the in-text enumeration starts with [2] and not [1]. Due to this buggy offset, the links in the list of links do not match the referenced places.

        Attachments

          Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-41672 Identical HTML links not enumerated correctly in forum post copies sent to email

          • Major - Major loss of function, incorrect output
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-37941 Automatic numbering of links in forum subscription mails starts with 2 instead of 1

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-38844 Hyperlinks in forum emails (text) starts counting from 2 instead 1

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-41705 Text-format mail from forum link numbering

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              mudrd8mz David Mudrák (@mudrd8mz)
              Reporter:
              mudrd8mz David Mudrák (@mudrd8mz)
              Integrator:
              Sam Hemelryk
              Tester:
              Andrew Davis
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Jul/13