Moodle
  1. Moodle
  2. MDL-35206

HTML links not enumerated correctly in forum post copies sent to email

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3, 2.4.3
    • Fix Version/s: 2.4.5, 2.5.1
    • Component/s: Forum
    • Labels:
    • Testing Instructions:
      Hide

      Testing difficulty: trivial

      • Log in (as a student, teacher or admin - does not matter) and modify your settings in the profile so that you want to receive e-mails in the plain text format. Make sure the messaging setting is set so the user receives subscribed forums posts via email.
      • Subscribe to a forum.
      • Submit a post into that forum. Make sure the post contains couple of HTML links.
      • Wait for the post coming to your inbox (you may want to use the "send emails immediately" feature).
      • TEST: Check that links are all listed at the bottom of the email, enumerated as [1], [2], [3] etc. and that they refer to a correct [1], [2], [3] etc. in the post text.
      Show
      Testing difficulty: trivial Log in (as a student, teacher or admin - does not matter) and modify your settings in the profile so that you want to receive e-mails in the plain text format. Make sure the messaging setting is set so the user receives subscribed forums posts via email. Subscribe to a forum. Submit a post into that forum. Make sure the post contains couple of HTML links. Wait for the post coming to your inbox (you may want to use the "send emails immediately" feature). TEST: Check that links are all listed at the bottom of the email, enumerated as [1] , [2] , [3] etc. and that they refer to a correct [1] , [2] , [3] etc. in the post text.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-35206-email-links

      Description

      I spotted this in the posts from "Integration, exposed" forum at moodle.org. In my preferences, I have selected "Plain text" as the format for the post from forums I am subscribed to. In this set-up, HTML links in the post body are converted into a numerical reference such as [1] or [2] and then there is a list of all links at the bottom of the text. The problem is that the in-text enumeration starts with [2] and not [1]. Due to this buggy offset, the links in the list of links do not match the referenced places.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            David Mudrak added a comment -

            Adding a copy of the email to illustrate the problem.

            Using Moodle -> Forums -> Integration, exposed -> Integration round 2012-08-31
            Summary - oh my, where is moodle.org?
            ---------------------------------------------------------------------
            Integration round 2012-08-31 Summary - oh my, where is moodle.org?
            by Eloy Lafuente (stronk7) - Friday, 31 August 2012, 10:09 PM
            ---------------------------------------------------------------------
            COLD NUMBERS: 
             
            52 ISSUES [2] have been successfully integrated with 18 rejected
            and 6 delayed. That is 74% SUCCESS, we need to improve! 
             
            NOTES: 
             
            Next week integration cycle will be the last one before PACKAGING AND
            RELEASING MOODLE 1.9.20 and 2.1.8 (ONLY SECURITY FIXES), and also 2.2.5 and
            2.3.2 (FULLY SUPPORTED). 
             
            Some interesting stuff is happening behind the scenes, that will debut with
            MOODLE 2.4 [3] LATER THIS YEAR. Time runs so, the sooner things land, the
            better. CODE FREEZE is planned for early November. AND THE RELEASE, on
            month later. 
             
            It's important to take a look to the DEVELOPMENT DOCUMENTATION THAT YOU
            NEED TO COMPLETE [4], to allow everybody to know how to play with your
            awesome code and APIs. Please, do it with the CARE you would expect from
            other Developers. 
             
            Today, for some hours, MOODLE.ORG [5] HAS BEEN KAPUT, down, unreachable,
            dead. 8-o 
             
            The cause for such a disaster, discovered after a RIGOROUS INVESTIGATION by
            the Moodle MiB [6], has been an elephant that accessed (flying, through
            the window!) to MOODLE HQ and, with the help of 2 dangerous
            peanuts, threatened everybody, causing the CAOS and the MASS HYSTERIA,
            until our beloved SYSTEM ADMIN, MATT SHARPE, was able to TAME IT from
            Sidney, only armed with his remote console. KUDOS FOR MATT!  
             
            HOT TOPICS: 
             
             	* MDL-25492 - Fixes and improvements to the BB6 question importer.
             	* MDL-34290 - Important fixes both to file references handling and the
            Dropbox repository.
             	* MDL-29598 - Problems on restore with the handling of grade letters.
             	* MDL-34696 - Improvements to the enrolments subsystem.
             	* MDL-34192 - Problems grading in the assignment under Oracle.
             	* And lots more in areas like questions, html editor, courses,
            assignments, libraries, navigation...
             
            WARM THANKS: 
             
             	* To JEAN-MICHEL VEDRINE for his great collaboration fixing and
            improving various problems with question formats. (y)
             
            	* To DAMYON WIESE and RAYMOND ANTONIO (from Moodle Partner NetSpot) for
            their continue work fixing and polishing the new assignment module. (y)
             	* To everybody that has been involved with the GSOC 2012 [7], mentors,
            students, ... big thanks! (y)
             
            Ciao all, stronk7 :-)
             
            Links:
            ------
            [1]
            http://tracker.moodle.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+MDL+AND+%22Integration+date%22+%3D+2012-08-31
            [2] http://docs.moodle.org/dev/Roadmap
            [3]
            http://tracker.moodle.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=labels+%3D+dev_docs_required+AND+assignee+%3D+currentUser%28%29
            [4] http://moodle.org
            [5] http://moodle.com/hq/team/
            [6] http://docs.moodle.org/dev/GSOC#2012
             
             
            ---------------------------------------------------------------------
            This is a copy of a message posted on the Using Moodle website.
             
            To reply click on this link:
            http://moodle.org/mod/forum/post.php?reply=916897
             
            ---------------------------------------------------------------------
            Unsubscribe from this forum: http://moodle.org/mod/forum/subscribe.php?id=1153
            

            Show
            David Mudrak added a comment - Adding a copy of the email to illustrate the problem. Using Moodle -> Forums -> Integration, exposed -> Integration round 2012-08-31 Summary - oh my, where is moodle.org? --------------------------------------------------------------------- Integration round 2012-08-31 Summary - oh my, where is moodle.org? by Eloy Lafuente (stronk7) - Friday, 31 August 2012, 10:09 PM --------------------------------------------------------------------- COLD NUMBERS:   52 ISSUES [2] have been successfully integrated with 18 rejected and 6 delayed. That is 74% SUCCESS, we need to improve!   NOTES:   Next week integration cycle will be the last one before PACKAGING AND RELEASING MOODLE 1.9.20 and 2.1.8 (ONLY SECURITY FIXES), and also 2.2.5 and 2.3.2 (FULLY SUPPORTED).   Some interesting stuff is happening behind the scenes, that will debut with MOODLE 2.4 [3] LATER THIS YEAR. Time runs so, the sooner things land, the better. CODE FREEZE is planned for early November. AND THE RELEASE, on month later.   It's important to take a look to the DEVELOPMENT DOCUMENTATION THAT YOU NEED TO COMPLETE [4], to allow everybody to know how to play with your awesome code and APIs. Please, do it with the CARE you would expect from other Developers.   Today, for some hours, MOODLE.ORG [5] HAS BEEN KAPUT, down, unreachable, dead. 8-o   The cause for such a disaster, discovered after a RIGOROUS INVESTIGATION by the Moodle MiB [6], has been an elephant that accessed (flying, through the window!) to MOODLE HQ and, with the help of 2 dangerous peanuts, threatened everybody, causing the CAOS and the MASS HYSTERIA, until our beloved SYSTEM ADMIN, MATT SHARPE, was able to TAME IT from Sidney, only armed with his remote console. KUDOS FOR MATT!   HOT TOPICS:   * MDL-25492 - Fixes and improvements to the BB6 question importer. * MDL-34290 - Important fixes both to file references handling and the Dropbox repository. * MDL-29598 - Problems on restore with the handling of grade letters. * MDL-34696 - Improvements to the enrolments subsystem. * MDL-34192 - Problems grading in the assignment under Oracle. * And lots more in areas like questions, html editor, courses, assignments, libraries, navigation...   WARM THANKS:   * To JEAN-MICHEL VEDRINE for his great collaboration fixing and improving various problems with question formats. (y)   * To DAMYON WIESE and RAYMOND ANTONIO (from Moodle Partner NetSpot) for their continue work fixing and polishing the new assignment module. (y) * To everybody that has been involved with the GSOC 2012 [7], mentors, students, ... big thanks! (y)   Ciao all, stronk7 :-)   Links: ------ [1] http://tracker.moodle.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+MDL+AND+%22Integration+date%22+%3D+2012-08-31 [2] http://docs.moodle.org/dev/Roadmap [3] http://tracker.moodle.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=labels+%3D+dev_docs_required+AND+assignee+%3D+currentUser%28%29 [4] http://moodle.org [5] http://moodle.com/hq/team/ [6] http://docs.moodle.org/dev/GSOC#2012     --------------------------------------------------------------------- This is a copy of a message posted on the Using Moodle website.   To reply click on this link: http://moodle.org/mod/forum/post.php?reply=916897   --------------------------------------------------------------------- Unsubscribe from this forum: http://moodle.org/mod/forum/subscribe.php?id=1153
            Hide
            Michael de Raadt added a comment - - edited

            This issue has now been duplicated at least twice.

            Who are all these people who continue to use text-only email?

            Show
            Michael de Raadt added a comment - - edited This issue has now been duplicated at least twice. Who are all these people who continue to use text-only email?
            Hide
            Alexander Bias added a comment -

            These people like a well-styled, mono-spaced, continuous, plain-text reading experience without any visual clutter and embedded images

            Show
            Alexander Bias added a comment - These people like a well-styled, mono-spaced, continuous, plain-text reading experience without any visual clutter and embedded images
            Hide
            Mark Nelson added a comment -

            This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

            For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

            Show
            Mark Nelson added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment
            Hide
            David Mudrak added a comment -

            Submitting for integration into 2.6, 2.5 and 2.4.

            Show
            David Mudrak added a comment - Submitting for integration into 2.6, 2.5 and 2.4.
            Hide
            Sam Hemelryk added a comment -

            Thanks David, this has been integrated now.

            Show
            Sam Hemelryk added a comment - Thanks David, this has been integrated now.
            Hide
            Andrew Davis added a comment -

            Works as described. Passing.

            Show
            Andrew Davis added a comment - Works as described. Passing.
            Hide
            Damyon Wiese added a comment -

            This issue is fixed! Hurray! Hurray!
            Your issue is fixed, what a wonderful day!

            Cheers, Damyon

            Show
            Damyon Wiese added a comment - This issue is fixed! Hurray! Hurray! Your issue is fixed, what a wonderful day! Cheers, Damyon

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: