Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35211

Since MDL-34916 strings describing how to use custom logos, in formal_white settings page, should be updated

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.2.6, 2.3.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Go to FW settings page and look at the description of customlogourl and frontpagelogourl.
      They should display an example for relative path too.

      Show
      Go to FW settings page and look at the description of customlogourl and frontpagelogourl. They should display an example for relative path too.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-35211_master

      Description

      As suggested by Andreabix in MDL-34916:
      "since now Formal White supports full URLs as well as relative paths, the theme settings descritive texts could be updated as well, adding examples of full log URL (already present) and a relativhe logo path as well (currently missing)"

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            lazydaisy Mary Evans added a comment -

            I totally agree!

            Show
            lazydaisy Mary Evans added a comment - I totally agree!
            Hide
            andreabix Andrea Bicciolo added a comment -

            Hi Daniele, strings appears OK, I'd suggest only to change ".local" (which could be misleading) into ".tld"

            Show
            andreabix Andrea Bicciolo added a comment - Hi Daniele, strings appears OK, I'd suggest only to change ".local" (which could be misleading) into ".tld"
            Hide
            daniss Daniele Cordella added a comment -

            @Andrea, as of our conversations strings pushed to github are ok now? Am I wrong?

            Show
            daniss Daniele Cordella added a comment - @Andrea, as of our conversations strings pushed to github are ok now? Am I wrong?
            Hide
            andreabix Andrea Bicciolo added a comment -

            Looks ok. Thanks

            Show
            andreabix Andrea Bicciolo added a comment - Looks ok. Thanks
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.

            This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody.

            This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P

            Apologises for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday. This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P Apologises for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Daniele, this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Daniele, this has been integrated now
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks Daniele,

            String contains both relative and absolute paths.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks Daniele, String contains both relative and absolute paths.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            From somewhere within the clouds...

            Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - From somewhere within the clouds... Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/12