[MDL-35215] Help popups misaligned for right-to-left languages - Moodle Tracker

XML

Word

Printable

Details

Type: Sub-task
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.1.7, 2.2.4, 2.2.5, 2.3.1, 2.3.2
Fix Version/s: 2.2.6, 2.3.3, STABLE backlog
Component/s: Libraries, Themes
Labels:
- patch
- rtl
- triaged
- yui

Affected Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Pull from Repository:
git://github.com/totara/moodle/
Pull Master Branch:
master_~~MDL-35215~~
Pull Master Diff URL:
https://github.com/totara/moodle/compare/master_MDL-35215
Testing Instructions:

Hide

1. Install a right-to-left language pack such as Hebrew or Arabic.
2. Login and edit your profile in English
3. Click a help icon
4. Help popups open to the right of the icon, away from the label
5. Switch your language to Hebrew/Arabic and save
6. Press browser back button to get back to edit profile and refresh page
7. Click a help icon
8. Help popups still open to the right so the label is obscured and the 'close' image is still in the top right

With patch applied:

IMPORTANT: Purge all caches (Site Administration > Development > Purge all caches) prior to TESTING

8. Help popups open the 'opposite' way and the close icon is in the correct location.

Show
1. Install a right-to-left language pack such as Hebrew or Arabic. 2. Login and edit your profile in English 3. Click a help icon 4. Help popups open to the right of the icon, away from the label 5. Switch your language to Hebrew/Arabic and save 6. Press browser back button to get back to edit profile and refresh page 7. Click a help icon 8. Help popups still open to the right so the label is obscured and the 'close' image is still in the top right With patch applied: IMPORTANT: Purge all caches (Site Administration > Development > Purge all caches) prior to TESTING 8. Help popups open the 'opposite' way and the close icon is in the correct location.

Description

When using Moodle in right-to-left (RTL) languages the help popups open the wrong way, which can obscure the label.

Attachments

Issue Links

will help resolve

MDL-35244 META: tasks related to RTL theme fixes before 2.4 freeze

Closed

Activity

People

Assignee:: Simon Coggins

Reporter:: Simon Coggins

Peer reviewer:: Mary Evans

Integrator:: Dan Poltawski

Tester:: Ankit Agarwal

Participants:: Andrew Lyons, Ankit Agarwal, Dan Poltawski, Mary Evans, Michael de Raadt, Nadav Kavalerchik, Petr Skoda, Simon Coggins

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Huong Nguyen, Bas Brands, Mathew May

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 04/Sep/12 1:21 PM

Updated:: 01/Nov/12 11:03 PM

Resolved:: 01/Nov/12 11:03 PM

Fix Release Date:: 12/Nov/12