Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35220

Block course overview collapsible areas create invalid HTML

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Inactive
    • Affects Version/s: 2.3.1
    • Fix Version/s: None
    • Component/s: Blocks, Dashboard (My home)
    • Labels:
    • Testing Instructions:
      Hide

      Pre-requisites

      • A course with a student enrolled
      • Some activity in the course (create some topics in the News forum)
      • Atleast two assignments
      • JavaScript enabled

      Steps

      1. Login as a student
      2. Go to My Moodle
      3. You should see "There are new forum posts"
      4. You should see "There are assignments that need your attention"

      Ensure the look and feel is similar to stable except it's clear you can expand the Alert Text to display more information.

      Show
      Pre-requisites A course with a student enrolled Some activity in the course (create some topics in the News forum) Atleast two assignments JavaScript enabled Steps Login as a student Go to My Moodle You should see "There are new forum posts" You should see "There are assignments that need your attention" Ensure the look and feel is similar to stable except it's clear you can expand the Alert Text to display more information.
    • Affected Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-35220-master

      Description

      When viewing My Moodle, the collapsible areas create invalid HTML by encapsulating <a> tags within others.

      Pre-requisites

      • A course with a student enrolled
      • Some activity in the course (create some topics in the News forum)
      • JavaScript enabled

      Steps

      1. Login as a student
      2. Go to My Moodle
      3. You should see "There are new forum posts"

      Actual:

      • Clicking on 'There are new forum posts' expands the area
      • The link 'There are new forum posts' contains all the content (other <a>s, etc...), this is invalid.

      Expected:

      • Display to the user that this is a collapsible area (use collapse icon)
      • Do not add the content in the <a> tag
      • (Using the core collapsible method? See javascript-static.js)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              fred Frédéric Massart
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: