Moodle

Feedback items cannot be unrequired using the checkbox on the several item forms

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.1.7, 2.2.4, 2.3.1
  • Fix Version/s: 2.2.7, 2.3.4, 2.4.1
  • Component/s: Feedback
  • Labels:
  • Testing Instructions:
    Hide
    1. Enable the feedback activity in the Site administration
    2. Create a new Feedback activity
    3. Add and save a new multichoice question, making it required
    4. Click the pen-in-hand icon to edit the question
    5. Uncheck the "Required" box and save changes
    6. The question is not required anymore.
    Show
    Enable the feedback activity in the Site administration Create a new Feedback activity Add and save a new multichoice question, making it required Click the pen-in-hand icon to edit the question Uncheck the "Required" box and save changes The question is not required anymore.
  • Workaround:
    Hide

    On the main "Edit questions" screen you can use the exclamation point icon to toggle whether or not a question is required.

    Show
    On the main "Edit questions" screen you can use the exclamation point icon to toggle whether or not a question is required.
  • Affected Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
  • Pull Master Branch:
  • Pull Master Diff URL:

Description

Create a new Feedback activity
Add and save a new multichoice question, making it required
Click the pen-in-hand icon to edit the question
Uncheck the "Required" box and save changes

The question should no longer be required, but it still is.

The problem affects all question types that can be required.

To fix the problem use 'advcheckbox' instead of 'checkbox' so that an unchecked box will submit a zero. I will post patches for all versions shortly.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36344 Feedback: failed to switch question from 'required' to normal from the question editing menu.

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
will be (partly) resolved by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36909 Review all usage of "checkbox" element and replace with "advcheckbox" if required

  • Minor - Minor loss of function where workaround is possible
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andreas Grabs added a comment -

Hi Kevin, thank you very much!
Andreas

Show
Andreas Grabs added a comment - Hi Kevin, thank you very much! Andreas
Hide
Permalink
Michael de Raadt added a comment -

When you're ready, Andreas, please request a peer review on this.

Show
Michael de Raadt added a comment - When you're ready, Andreas, please request a peer review on this.
Hide
Permalink
Ankit Agarwal added a comment -

Hi Andreas,
The patch looks good. I linked the generic checkbox issue for reference.

However I don’t follow why you have set the class to "checkbox1" . can you justify that please?
Also it will be good to have some testing instructions.

Thanks for working on the issue.

Show
Ankit Agarwal added a comment - Hi Andreas, The patch looks good. I linked the generic checkbox issue for reference. However I don’t follow why you have set the class to "checkbox1" . can you justify that please? Also it will be good to have some testing instructions. Thanks for working on the issue.
Hide
Permalink
Andreas Grabs added a comment -

Hi Ankit,
the patch isn't mine. But it looks ok.
I don't know what class do you mean. Where is a class set to "checkbox1"?
The testing instructions come soon.
Andreas

Show
Andreas Grabs added a comment - Hi Ankit, the patch isn't mine. But it looks ok. I don't know what class do you mean. Where is a class set to "checkbox1"? The testing instructions come soon. Andreas
Hide
Permalink
Ankit Agarwal added a comment - - edited

Hi Andreas,
Sorry didnt notice branches where not on your repo.

Also it is "checkboxgroup1". Sorry for the typo.

I am talking about the argument array('group' => 1) for the advcheckbox elements. That is generating the class identifier.
Have a look on how its handled in moodleQuickForm_advcheckbox::__constructor()

Thanks

Show
Ankit Agarwal added a comment - - edited Hi Andreas, Sorry didnt notice branches where not on your repo. Also it is "checkboxgroup1". Sorry for the typo. I am talking about the argument array('group' => 1) for the advcheckbox elements. That is generating the class identifier. Have a look on how its handled in moodleQuickForm_advcheckbox::__constructor() Thanks
Hide
Permalink
Kevin Wiliarty added a comment -

Shall I change that parameter to 'null'? I agree that it is not serving a purpose to assign it to a class when there is no controller (and no need for one).

Show
Kevin Wiliarty added a comment - Shall I change that parameter to 'null'? I agree that it is not serving a purpose to assign it to a class when there is no controller (and no need for one).
Hide
Permalink
Kevin Wiliarty added a comment -

I'm going to go ahead and switch those fifth arguments to nulls.

Show
Kevin Wiliarty added a comment - I'm going to go ahead and switch those fifth arguments to nulls.
Hide
Permalink
Kevin Wiliarty added a comment -

Okay. All the patch branches on my github repo should now have 

$mform->addElement('advcheckbox', 'required', get_string('required', 'feedback'), '' , null , array(0, 1));

in place of 

$mform->addElement('advcheckbox', 'required', get_string('required', 'feedback'), '' , array('group'=>1) , array(0, 1));

in all the relevant files.

Thanks for the input!

Show
Kevin Wiliarty added a comment - Okay. All the patch branches on my github repo should now have $mform->addElement('advcheckbox', 'required', get_string('required', 'feedback'), '' , null , array(0, 1)); in place of $mform->addElement('advcheckbox', 'required', get_string('required', 'feedback'), '' , array('group'=>1) , array(0, 1)); in all the relevant files. Thanks for the input!
Hide
Permalink
Ankit Agarwal added a comment -

Thanks for the update Kevin.
Submitting for integration.

Show
Ankit Agarwal added a comment - Thanks for the update Kevin. Submitting for integration.
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Kevin, your fix has been integrated now.

Show
Sam Hemelryk added a comment - Thanks Kevin, your fix has been integrated now.
Hide
Permalink
Rajesh Taneja added a comment -

Thanks Andreas,

Works fine.

Show
Rajesh Taneja added a comment - Thanks Andreas, Works fine.
Hide
Permalink
Andreas Grabs added a comment -

Thank you too. But it wasn't me. The patch was contributed by Kevin.
Thank you Kevin!
Best regards
Andreas

Show
Andreas Grabs added a comment - Thank you too. But it wasn't me. The patch was contributed by Kevin. Thank you Kevin! Best regards Andreas
Hide
Permalink
Kevin Wiliarty added a comment -

I'm still learning the procedures. Is it for me to close the ticket, then?
Kevin

Show
Kevin Wiliarty added a comment - I'm still learning the procedures. Is it for me to close the ticket, then? Kevin
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

Closing, ciao

Show
Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

People

Vote (4)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: