Hi Kevin, thank you very much!
Andreas

When you're ready, Andreas, please request a peer review on this.

Hi Andreas,
The patch looks good. I linked the generic checkbox issue for reference.

However I don’t follow why you have set the class to "checkbox1" . can you justify that please?
Also it will be good to have some testing instructions.

Thanks for working on the issue.

Hi Ankit,
the patch isn't mine. But it looks ok.
I don't know what class do you mean. Where is a class set to "checkbox1"?
The testing instructions come soon.
Andreas

Hi Andreas,
Sorry didnt notice branches where not on your repo.

Also it is "checkboxgroup1". Sorry for the typo.

I am talking about the argument array('group' => 1) for the advcheckbox elements. That is generating the class identifier.
Have a look on how its handled in moodleQuickForm_advcheckbox::__constructor()

Thanks

Shall I change that parameter to 'null'? I agree that it is not serving a purpose to assign it to a class when there is no controller (and no need for one).

I'm going to go ahead and switch those fifth arguments to nulls.

Okay. All the patch branches on my github repo should now have

$mform->addElement('advcheckbox', 'required', get_string('required', 'feedback'), '' , null , array(0, 1));

in place of

$mform->addElement('advcheckbox', 'required', get_string('required', 'feedback'), '' , array('group'=>1) , array(0, 1));

in all the relevant files.

Thanks for the input!

Thanks for the update Kevin.
Submitting for integration.

Thanks Kevin, your fix has been integrated now.

Thanks Andreas,

Works fine.

Thank you too. But it wasn't me. The patch was contributed by Kevin.
Thank you Kevin!
Best regards
Andreas

I'm still learning the procedures. Is it for me to close the ticket, then?
Kevin

Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

Closing, ciao