Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35221

Feedback items cannot be unrequired using the checkbox on the several item forms

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.7, 2.2.4, 2.3.1
    • Fix Version/s: 2.2.7, 2.3.4, 2.4.1
    • Component/s: Feedback
    • Labels:
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:
    • Pull Master Diff URL:
    • Workaround:
      Hide

      On the main "Edit questions" screen you can use the exclamation point icon to toggle whether or not a question is required.

      Show
      On the main "Edit questions" screen you can use the exclamation point icon to toggle whether or not a question is required.
    • Testing Instructions:
      Hide
      1. Enable the feedback activity in the Site administration
      2. Create a new Feedback activity
      3. Add and save a new multichoice question, making it required
      4. Click the pen-in-hand icon to edit the question
      5. Uncheck the "Required" box and save changes
      6. The question is not required anymore.
      Show
      Enable the feedback activity in the Site administration Create a new Feedback activity Add and save a new multichoice question, making it required Click the pen-in-hand icon to edit the question Uncheck the "Required" box and save changes The question is not required anymore.

      Description

      Create a new Feedback activity
      Add and save a new multichoice question, making it required
      Click the pen-in-hand icon to edit the question
      Uncheck the "Required" box and save changes

      The question should no longer be required, but it still is.

      The problem affects all question types that can be required.

      To fix the problem use 'advcheckbox' instead of 'checkbox' so that an unchecked box will submit a zero. I will post patches for all versions shortly.

        Attachments

          Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36344 Feedback: failed to switch question from 'required' to normal from the question editing menu.

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will be (partly) resolved by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36909 Review all usage of "checkbox" element and replace with "advcheckbox" if required

          • Minor - Minor loss of function where workaround is possible
          • Open

            Activity

              People

              Assignee:
              grabs Andreas Grabs
              Reporter:
              kwiliarty Kevin Wiliarty
              Peer reviewer:
              Ankit Agarwal Ankit Agarwal
              Integrator:
              Sam Hemelryk Sam Hemelryk
              Tester:
              Rajesh Taneja Rajesh Taneja
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              4 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Jan/13