Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2, 2.4
    • Fix Version/s: 2.3.3
    • Component/s: Accessibility, Book
    • Labels:
    • Rank:
      43867

      Description

      Multipage items (e.g. Book, Activity Reports, Calendar) should have their page titles change to indicate to the user which page of a resource they are viewing instead of always keeping the same title.

      Greg's comment on MDL-30896 suggest
      For books, each chapter should have a unique page title that incorporates the chapter title
      "Introduction: Welcome to the course"

      instead of every page just saying

      "Introduction"

        Activity

        Hide
        Ankit Agarwal added a comment -

        Requesting a review.
        Thanks

        Show
        Ankit Agarwal added a comment - Requesting a review. Thanks
        Hide
        Adrian Greeve added a comment -

        Hi Ankit,

        The patch looks good. I can't find anything wrong with it.

        Thanks.

        Show
        Adrian Greeve added a comment - Hi Ankit, The patch looks good. I can't find anything wrong with it. Thanks.
        Hide
        Ankit Agarwal added a comment -

        Thanks for the review Adrian.
        Sending for integration!

        Thanks

        Show
        Ankit Agarwal added a comment - Thanks for the review Adrian. Sending for integration! Thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Ankit Agarwal added a comment -

        rebased
        thanks

        Show
        Ankit Agarwal added a comment - rebased thanks
        Hide
        Aparup Banerjee added a comment -

        Thanks, thats been integrated for testing into master and 23.

        Show
        Aparup Banerjee added a comment - Thanks, thats been integrated for testing into master and 23.
        Hide
        Adrian Greeve added a comment -

        Tested in 2.2, 2.3 and master integration branches.
        The book page titles look good.
        Test passed.

        Show
        Adrian Greeve added a comment - Tested in 2.2, 2.3 and master integration branches. The book page titles look good. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio

        This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

        Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: