Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.4
    • Component/s: Accessibility, Lesson
    • Labels:
    • Testing Instructions:
      Hide

      This issue adds a unique title to every page of a lesson. So idea is basically to traverse through all possible cases and make sure they have unique label. So "check the title" means make sure the lesson page has a UNIQUE descriptive title.

      1. Create a lesson
      2. Set lesson "available from" date in future
      3. Add all possible types of pages (make sure you design next page options properly so you can traverse later)
      4. Add all possible types of question types
      5. Try accessing the lesson
      6. Check the title as student
      7. Edit lesson setting, disable "Available from" date , enable deadline and set deadline to a past date
      8. check the title as student
      9. Edit lesson setting, disable "deadline" date , enable Dependent on and set it to some condition which your student doesnt have.
      10. check title as student
      11. edit lesson setting, undo "Dependent on" settings, Enable a password on lesson
      12. check title as student on the lesson login page
      13. enter password
      14. Traverse through all pages created in step 3 and 4 and check title for each page (As student)
      15. Check the title in end of lesson page as student
      16. Edit settings and undo previous changes and set retake allowed to No
      17. Check the title as student (You should see a page saying you cannot retake lesson if you completed step #14 properly)
      18. Edit settings and undo previous changes
      19. goto reports page as teacher
      20. Check the title as teacher
      21. goto detailed stats
      22. check the title as teacher
      23. Delete all attempts
      24. goto detailed stats
      25. check the title as teacher
      26. goto to edit lesson tab
      27. check title as teacher
      28. goto grade essays page
      29. check the title as teacher
      30. Goto something like moodle/mod/lesson/highscores.php?id=272 (No idea how to reach that page from UI)
      31. check the title as teacher
      32. Goto edit>edit a page
      33. check title as teacher
      34. goto edit>move a page
      35. check title as teacher
      36. goto edit>Delete a page
      37. check title as teacher
      38. Edit your multichoice question page and add some response text
      39. attempt the page as student, and answer the question and make sure you see the response text page
      40. check the title of the response text page as student
      Show
      This issue adds a unique title to every page of a lesson. So idea is basically to traverse through all possible cases and make sure they have unique label. So "check the title" means make sure the lesson page has a UNIQUE descriptive title. Create a lesson Set lesson "available from" date in future Add all possible types of pages (make sure you design next page options properly so you can traverse later) Add all possible types of question types Try accessing the lesson Check the title as student Edit lesson setting, disable "Available from" date , enable deadline and set deadline to a past date check the title as student Edit lesson setting, disable "deadline" date , enable Dependent on and set it to some condition which your student doesnt have. check title as student edit lesson setting, undo "Dependent on" settings, Enable a password on lesson check title as student on the lesson login page enter password Traverse through all pages created in step 3 and 4 and check title for each page (As student) Check the title in end of lesson page as student Edit settings and undo previous changes and set retake allowed to No Check the title as student (You should see a page saying you cannot retake lesson if you completed step #14 properly) Edit settings and undo previous changes goto reports page as teacher Check the title as teacher goto detailed stats check the title as teacher Delete all attempts goto detailed stats check the title as teacher goto to edit lesson tab check title as teacher goto grade essays page check the title as teacher Goto something like moodle/mod/lesson/highscores.php?id=272 (No idea how to reach that page from UI) check the title as teacher Goto edit>edit a page check title as teacher goto edit>move a page check title as teacher goto edit>Delete a page check title as teacher Edit your multichoice question page and add some response text attempt the page as student, and answer the question and make sure you see the response text page check the title of the response text page as student
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-35226-master
    • Rank:
      43870

      Description

      Multipage items (e.g. Book, Activity Reports, Calendar) should have their page titles change to indicate to the user which page of a resource they are viewing instead of always keeping the same title.

        Activity

        Hide
        Ankit Agarwal added a comment -

        I have left mediafile.php unchanged, since I donot think that file is used anywhere any more.

        Show
        Ankit Agarwal added a comment - I have left mediafile.php unchanged, since I donot think that file is used anywhere any more.
        Hide
        Ankit Agarwal added a comment -

        Requesting a review.
        Thanks!

        Show
        Ankit Agarwal added a comment - Requesting a review. Thanks!
        Hide
        Adrian Greeve added a comment - - edited

        Hi Ankit,

        Everything looks great.
        No problems encountered.
        I went through a good proportion of the testing instructions, but not all of them. I'm confident that it will make it through with no problems.

        Thanks.

        Show
        Adrian Greeve added a comment - - edited Hi Ankit, Everything looks great. No problems encountered. I went through a good proportion of the testing instructions, but not all of them. I'm confident that it will make it through with no problems. Thanks.
        Hide
        Ankit Agarwal added a comment -

        Thanks for the review Adrian,
        Adding labels and submitting for integration.
        Thanks

        Show
        Ankit Agarwal added a comment - Thanks for the review Adrian, Adding labels and submitting for integration. Thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Ankit Agarwal added a comment -

        rebased
        Thanks

        Show
        Ankit Agarwal added a comment - rebased Thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (master only - 2.4), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (master only - 2.4), thanks!
        Hide
        Tim Barker added a comment -

        Don't like these testing instructions. Please make them more granular and easy to read in future Ankit!

        Show
        Tim Barker added a comment - Don't like these testing instructions. Please make them more granular and easy to read in future Ankit!
        Hide
        Rossiani Wijaya added a comment -

        Hi Ankit,

        I noticed these 2 issues:

        1. step 7 - lesson is closed but the header is 'not ready to be taken'
        2. step 24 - Notice: Undefined variable: actionfalse in /integration/master/mod/lesson/report.php on line 379

        The rest looks good.

        Show
        Rossiani Wijaya added a comment - Hi Ankit, I noticed these 2 issues: step 7 - lesson is closed but the header is 'not ready to be taken' step 24 - Notice: Undefined variable: actionfalse in /integration/master/mod/lesson/report.php on line 379 The rest looks good.
        Hide
        Helen Foster added a comment -

        From chatting with Ankit about this issue, we agreed that when a lesson is not available, the page title should include the phrase 'Not available'. The same phrase can then be used for all other activity modules.

        Show
        Helen Foster added a comment - From chatting with Ankit about this issue, we agreed that when a lesson is not available, the page title should include the phrase 'Not available'. The same phrase can then be used for all other activity modules.
        Hide
        Ankit Agarwal added a comment -

        Hi Eloy,
        I have made additional commit https://github.com/ankitagarwal/moodle/commit/d43d3418ff4d752bc480a1236676f04df2337b41 as per feedback from Rosie and Helen. Please pull it in.
        Thanks

        Show
        Ankit Agarwal added a comment - Hi Eloy, I have made additional commit https://github.com/ankitagarwal/moodle/commit/d43d3418ff4d752bc480a1236676f04df2337b41 as per feedback from Rosie and Helen. Please pull it in. Thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Commit added

        Show
        Eloy Lafuente (stronk7) added a comment - Commit added
        Hide
        Rossiani Wijaya added a comment -

        This is working great.

        Thanks for the quick fix and integration guys.

        Test passed.

        Show
        Rossiani Wijaya added a comment - This is working great. Thanks for the quick fix and integration guys. Test passed.
        Hide
        Dan Poltawski added a comment -

        Congratulations, you've done it!

        Thanks, this change is now in the latest weekly release!

        Join the crowds of people tomorrow from 8am and download this Moodle release from your local apple store!

        Show
        Dan Poltawski added a comment - Congratulations, you've done it! Thanks, this change is now in the latest weekly release! Join the crowds of people tomorrow from 8am and download this Moodle release from your local apple store!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: