Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35238 Automatic plugin update deployment
  3. MDL-35240

URL to download a new plugin version is not returned by download.moodle.org REST API

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Future Dev
    • Fix Version/s: 2.4
    • Component/s: Administration
    • Labels:
    • Fixed Branches:
      MOODLE_24_STABLE

      Description

      The REST web service at http://download.moodle.org/api/1.0/updates.php does not seem to provide URL to download the new plugin version. Such an URL should be returned via the 'download' property as it is for the Moodle core. Such URL is populated in local_plugins_version::get_downloadlink() method. To be able to fetch ZIPs automatically, we need this info available in Moodle clients.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            mudrd8mz David Mudrák added a comment -

            Assigning to Eloy as he seems to be the Best Man for this!

            Show
            mudrd8mz David Mudrák added a comment - Assigning to Eloy as he seems to be the Best Man for this!
            Hide
            mudrd8mz David Mudrák added a comment -

            Note that we might want to make this changes in a new version of the API at the URL http://download.moodle.org/api/1.1/updates.php

            Show
            mudrd8mz David Mudrák added a comment - Note that we might want to make this changes in a new version of the API at the URL http://download.moodle.org/api/1.1/updates.php
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            It's already working, showing fake downloadurl and downloadmd5 until moodle.org gets updates with the new version of local_plugins.

            Tell me what do you want in the case of downloadurl/downloadmd5 not being available or being empty (to replace current fake values with expected behavior).

            I know it's 99.99% unlikely... but... ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - It's already working, showing fake downloadurl and downloadmd5 until moodle.org gets updates with the new version of local_plugins. Tell me what do you want in the case of downloadurl/downloadmd5 not being available or being empty (to replace current fake values with expected behavior). I know it's 99.99% unlikely... but... ciao
            Hide
            mudrd8mz David Mudrák added a comment -

            Thanks Eloy. The only thing is the 'downloadurl' property name. It should be just 'download' as it's what all 2.3 sites around there expect and support (to display the 'Download' link).

            WRT missing value. If for some reason the value of the property can't be populated, just omit it from the response.

            Show
            mudrd8mz David Mudrák added a comment - Thanks Eloy. The only thing is the 'downloadurl' property name. It should be just 'download' as it's what all 2.3 sites around there expect and support (to display the 'Download' link). WRT missing value. If for some reason the value of the property can't be populated, just omit it from the response.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Done! Let's wait to local_plugins to be upgraded @ moodle.org

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Done! Let's wait to local_plugins to be upgraded @ moodle.org
            Hide
            poltawski Dan Poltawski added a comment -

            Taking these issues out of current integration (I don't think they are moodle issues needing action).

            Show
            poltawski Dan Poltawski added a comment - Taking these issues out of current integration (I don't think they are moodle issues needing action).
            Hide
            poltawski Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Closing as fixed. The 1.1 api is already supporting this.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Closing as fixed. The 1.1 api is already supporting this.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/12