Moodle

Translated log message

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1.8, 2.2.2, 2.3.1
  • Fix Version/s: 2.2.6, 2.3.3
  • Component/s: Web Services
  • Labels:
  • Testing Instructions:
    Hide

    Require web service client creation experience.

    1) Enable mobile service in the Moodle admin
    2) http://docs.moodle.org/dev/Creating_a_web_service_client#How_to_get_a_user_token
    Call login/token.php following the documentation. Checks Moodle logs (in the Moodle admin), you should see the new info about token created for the user.

    Show
    Require web service client creation experience. 1) Enable mobile service in the Moodle admin 2) http://docs.moodle.org/dev/Creating_a_web_service_client#How_to_get_a_user_token Call login/token.php following the documentation. Checks Moodle logs (in the Moodle admin), you should see the new info about token created for the user.
  • Affected Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_22_STABLE, MOODLE_23_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    MDL-35242-master
  • Pull Master Diff URL:

Description

I got this e-mail errormessage from my server:

array (
  'time' => 1346614071,
  'userid' => '5052',
  'course' => '1',
  'ip' => '91.177.224.235',
  'module' => 'webservice',
  'cmid' => 0,
  'action' => 'Maak automatisch een token voor een gebruiker',
  'url' => '',
  'info' => 'User ID: 5052',
)

The reason is that the error message is more then 40 chars long (size limit of the action field in the logs database)

But the point is that log messages shouldn't be translated (this one is in Dutch)

Issue Links

testing discovered

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-35473 add_to_log should check for string length

  • Minor - Minor loss of function where workaround is possible
  • Open - The issue is open and ready for the assignee to start work on it.

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-35636 login/token.php: confusing "create user token" log appearing before "token user request"

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jérôme Mouneyrac added a comment - - edited

thanks Koen,
note for later:

in login/token.php, remove the get_string() of this line:

add_to_log(SITEID, 'webservice', get_string('createtokenforuserauto', 'webservice'), '' , 'User ID: ' . $user->id);

and replace it by an english string. 'createtokenforuserauto' is most likely only use here, if it's the case remove the string from the lang file.

Show
Jérôme Mouneyrac added a comment - - edited thanks Koen, note for later: in login/token.php, remove the get_string() of this line: add_to_log(SITEID, 'webservice', get_string('createtokenforuserauto', 'webservice'), '' , 'User ID: ' . $user->id); and replace it by an english string. 'createtokenforuserauto' is most likely only use here, if it's the case remove the string from the lang file.
Hide
Permalink
Jérôme Mouneyrac added a comment - - edited

perfect, submitting. Integrator: can you cherry-pick 2.2 into 2.1, it should not create any conflict. Thank you.

Show
Jérôme Mouneyrac added a comment - - edited perfect, submitting. Integrator: can you cherry-pick 2.2 into 2.1, it should not create any conflict. Thank you.
Hide
Permalink
Dan Poltawski added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Dan Poltawski added a comment -

We really need a guidance document to point to developers and make the rules clear for this once and for all.

Show
Dan Poltawski added a comment - We really need a guidance document to point to developers and make the rules clear for this once and for all.
Hide
Permalink
Dan Poltawski added a comment -

Yay, you didn't remove the strings from the stable branches, great work

Show
Dan Poltawski added a comment - Yay, you didn't remove the strings from the stable branches, great work
Hide
Permalink
Dan Poltawski added a comment -

Thanks Fred, thats been integrated now.

Show
Dan Poltawski added a comment - Thanks Fred, thats been integrated now.
Hide
Permalink
Dan Poltawski added a comment -

Ah! Just noticed, no testing instructions.

Show
Dan Poltawski added a comment - Ah! Just noticed, no testing instructions.
Hide
Permalink
Jérôme Mouneyrac added a comment -

I added them

Show
Jérôme Mouneyrac added a comment - I added them
Hide
Permalink
Rajesh Taneja added a comment -

Thanks Fred, string looks fine.

FYI:
Log doesn't seem to be in order.
First log entry: webservice automatically create user token
Second log entry: webservice user request webservice token

IMO, it should be other way round. Passing this as this is not related to this fix.

Show
Rajesh Taneja added a comment - Thanks Fred, string looks fine. FYI: Log doesn't seem to be in order. First log entry: webservice automatically create user token Second log entry: webservice user request webservice token IMO, it should be other way round. Passing this as this is not related to this fix.
Hide
Permalink
Jérôme Mouneyrac added a comment -

Thanks Raj, I created http://tracker.moodle.org/browse/MDL-35636

Show
Jérôme Mouneyrac added a comment - Thanks Raj, I created http://tracker.moodle.org/browse/MDL-35636
Hide
Permalink
Dan Poltawski added a comment -

Congratulations, you've done it!

Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc

Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

Show
Dan Poltawski added a comment - Congratulations, you've done it! Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: