Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35245

Missing scrollbar in Activity Chooser, when in RTL mode

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.3, 2.4
    • Component/s: Themes
    • Labels:

      Description

      1. Missing scrollbar in Activity Chooser, when in RTL mode

      2. sub activities should be padded

      Example:

      Assignments
      File
      Multi Files
      Online
      ...

        Gliffy Diagrams

          Activity

          Hide
          nadavkav Nadav Kavalerchik added a comment - - edited
          Show
          nadavkav Nadav Kavalerchik added a comment - - edited proposed fix for issue number 1: https://github.com/nadavkav/moodle/commit/9291a200447a220a23c64ca7ede13195cf8f9531
          Show
          nadavkav Nadav Kavalerchik added a comment - proposed fix for issue number 2 : https://github.com/nadavkav/moodle/commit/85753eaf528891cc942c597c49bede3ff0c2b288
          Hide
          abgreeve Adrian Greeve added a comment -

          Tested on the master integration branch.
          screen shot viewed and fix verified.

          Show
          abgreeve Adrian Greeve added a comment - Tested on the master integration branch. screen shot viewed and fix verified.
          Hide
          poltawski Dan Poltawski added a comment -

          Congratulations, you've done it!

          Thanks, this change is now in the latest weekly release!

          Join the crowds of people tomorrow from 8am and download this Moodle release from your local apple store!

          Show
          poltawski Dan Poltawski added a comment - Congratulations, you've done it! Thanks, this change is now in the latest weekly release! Join the crowds of people tomorrow from 8am and download this Moodle release from your local apple store!
          Hide
          nadavkav Nadav Kavalerchik added a comment -

          @Mary
          I would like to reopen this issue, since I forgot to add a fix for Moodle 2.3.x (which I just now added)

          Show
          nadavkav Nadav Kavalerchik added a comment - @Mary I would like to reopen this issue, since I forgot to add a fix for Moodle 2.3.x (which I just now added)
          Hide
          lazydaisy Mary Evans added a comment -

          Nadav,
          I wish you would not do this.

          You cannot reopen when it has been fixed. You need to open a new issue to fix this latest addition. This means renaming your branch that you have just added here.

          Show
          lazydaisy Mary Evans added a comment - Nadav, I wish you would not do this. You cannot reopen when it has been fixed. You need to open a new issue to fix this latest addition. This means renaming your branch that you have just added here.
          Hide
          lazydaisy Mary Evans added a comment -

          I have just added a sub-task 35837. Please feel free to add the corrected branch into that.
          Thanks

          Show
          lazydaisy Mary Evans added a comment - I have just added a sub-task 35837. Please feel free to add the corrected branch into that. Thanks
          Hide
          nadavkav Nadav Kavalerchik added a comment -

          Ok. It does not matter if this issue is reopened or a new one is opened.
          I will upload my missed M23 fix to MDL-35837

          Show
          nadavkav Nadav Kavalerchik added a comment - Ok. It does not matter if this issue is reopened or a new one is opened. I will upload my missed M23 fix to MDL-35837

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                25/Jun/12