Moodle
  1. Moodle
  2. MDL-35245

Missing scrollbar in Activity Chooser, when in RTL mode

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.3, 2.4
    • Component/s: Themes
    • Labels:
    • Rank:
      43895

      Description

      1. Missing scrollbar in Activity Chooser, when in RTL mode

      2. sub activities should be padded

      Example:

      Assignments
      File
      Multi Files
      Online
      ...

        Activity

        Hide
        Nadav Kavalerchik added a comment - - edited
        Show
        Nadav Kavalerchik added a comment - - edited proposed fix for issue number 1: https://github.com/nadavkav/moodle/commit/9291a200447a220a23c64ca7ede13195cf8f9531
        Show
        Nadav Kavalerchik added a comment - proposed fix for issue number 2 : https://github.com/nadavkav/moodle/commit/85753eaf528891cc942c597c49bede3ff0c2b288
        Hide
        Adrian Greeve added a comment -

        Tested on the master integration branch.
        screen shot viewed and fix verified.

        Show
        Adrian Greeve added a comment - Tested on the master integration branch. screen shot viewed and fix verified.
        Hide
        Dan Poltawski added a comment -

        Congratulations, you've done it!

        Thanks, this change is now in the latest weekly release!

        Join the crowds of people tomorrow from 8am and download this Moodle release from your local apple store!

        Show
        Dan Poltawski added a comment - Congratulations, you've done it! Thanks, this change is now in the latest weekly release! Join the crowds of people tomorrow from 8am and download this Moodle release from your local apple store!
        Hide
        Nadav Kavalerchik added a comment -

        @Mary
        I would like to reopen this issue, since I forgot to add a fix for Moodle 2.3.x (which I just now added)

        Show
        Nadav Kavalerchik added a comment - @Mary I would like to reopen this issue, since I forgot to add a fix for Moodle 2.3.x (which I just now added)
        Hide
        Mary Evans added a comment -

        Nadav,
        I wish you would not do this.

        You cannot reopen when it has been fixed. You need to open a new issue to fix this latest addition. This means renaming your branch that you have just added here.

        Show
        Mary Evans added a comment - Nadav, I wish you would not do this. You cannot reopen when it has been fixed. You need to open a new issue to fix this latest addition. This means renaming your branch that you have just added here.
        Hide
        Mary Evans added a comment -

        I have just added a sub-task 35837. Please feel free to add the corrected branch into that.
        Thanks

        Show
        Mary Evans added a comment - I have just added a sub-task 35837. Please feel free to add the corrected branch into that. Thanks
        Hide
        Nadav Kavalerchik added a comment -

        Ok. It does not matter if this issue is reopened or a new one is opened.
        I will upload my missed M23 fix to MDL-35837

        Show
        Nadav Kavalerchik added a comment - Ok. It does not matter if this issue is reopened or a new one is opened. I will upload my missed M23 fix to MDL-35837

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: