Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.4
    • Component/s: Themes
    • Labels:
    • Rank:
      43898

      Description

      Left justify CLOSE button on users modal dialog, when in RTL mode
      (Or left justify Title?)

      And probably on other Modal dialogs too

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          It would be good if they didn't overlap. Where is a close button normally located in the RTL world?

          Show
          Michael de Raadt added a comment - It would be good if they didn't overlap. Where is a close button normally located in the RTL world?
          Hide
          Nadav Kavalerchik added a comment -

          "Close" button in RTL UI is always to the left.
          (Actually (Funny too), The entire RTL UI world is a mirror of the LTR universe )

          Show
          Nadav Kavalerchik added a comment - "Close" button in RTL UI is always to the left. (Actually (Funny too), The entire RTL UI world is a mirror of the LTR universe )
          Hide
          Adrian Greeve added a comment -

          While this does fix the enrolment modal dialog box, it doesn't fix the activity picker or the create new question modal dialog boxes.

          Show
          Adrian Greeve added a comment - While this does fix the enrolment modal dialog box, it doesn't fix the activity picker or the create new question modal dialog boxes.
          Hide
          Dan Poltawski added a comment -

          I think its best if we address these as new issues, at least we've got 1/3 done. Please can you create a new issue, Adrian?

          Show
          Dan Poltawski added a comment - I think its best if we address these as new issues, at least we've got 1/3 done. Please can you create a new issue, Adrian?
          Hide
          Nadav Kavalerchik added a comment -

          Adrian,
          The Dialog's Title in Activity Chooser is centered and does not seems to have any UI problem (even though the close button could be align to the left)
          Leave it be

          Show
          Nadav Kavalerchik added a comment - Adrian, The Dialog's Title in Activity Chooser is centered and does not seems to have any UI problem (even though the close button could be align to the left) Leave it be
          Hide
          Nadav Kavalerchik added a comment -

          Adrian, I have just uploaded a proper fix for this issue as a separate branch, hope it makes it easier to test

          Show
          Nadav Kavalerchik added a comment - Adrian, I have just uploaded a proper fix for this issue as a separate branch, hope it makes it easier to test
          Hide
          Adrian Greeve added a comment -

          Tested again, still works
          Issues have been created for the other modal dialog boxes, to maintain continuity of the close button.
          Test passed.

          Show
          Adrian Greeve added a comment - Tested again, still works Issues have been created for the other modal dialog boxes, to maintain continuity of the close button. Test passed.
          Hide
          Dan Poltawski added a comment -

          Congratulations, you've done it!

          Thanks, this change is now in the latest weekly release!

          Join the crowds of people tomorrow from 8am and download this Moodle release from your local apple store!

          Show
          Dan Poltawski added a comment - Congratulations, you've done it! Thanks, this change is now in the latest weekly release! Join the crowds of people tomorrow from 8am and download this Moodle release from your local apple store!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: